You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/09 05:30:07 UTC

[GitHub] [superset] mayurnewase opened a new issue #13522: [documentation]: updating db migration in contribution file

mayurnewase opened a new issue #13522:
URL: https://github.com/apache/superset/issues/13522


   A clear and concise description of what the bug is.
   
   Currently, contribution.md suggests merging db migration heads in case of conflicts, which creates 2 migration files for single feature/pr which works locally perfectly but may not be ideal to merge in master.
   
   ### Expected results
   The contribution file should have notes about how to fix migration for pr by using positioning current migration on the top by changing parent revision to latest head or making new migration after merging.
   
   
   - [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [ ] I have reproduced the issue with at least the latest released version of superset.
   - [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   Add any other context about the problem here.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] mayurnewase commented on issue #13522: [documentation]: updating db migration in contribution file

Posted by GitBox <gi...@apache.org>.
mayurnewase commented on issue #13522:
URL: https://github.com/apache/superset/issues/13522#issuecomment-794959428


   Closing this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on issue #13522: [documentation]: updating db migration in contribution file

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #13522:
URL: https://github.com/apache/superset/issues/13522#issuecomment-794945221


   @mayurnewase feel free to add notes. 🙏
   
   cc @ktmud
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] mayurnewase commented on issue #13522: [documentation]: updating db migration in contribution file

Posted by GitBox <gi...@apache.org>.
mayurnewase commented on issue #13522:
URL: https://github.com/apache/superset/issues/13522#issuecomment-794959304


   Yeah exactly.
   Sorry didn't see that pr.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on issue #13522: [documentation]: updating db migration in contribution file

Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #13522:
URL: https://github.com/apache/superset/issues/13522#issuecomment-794973016


   No need to feel sorry and thanks for raising this issue! Great minds think alike 😉 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on issue #13522: [documentation]: updating db migration in contribution file

Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #13522:
URL: https://github.com/apache/superset/issues/13522#issuecomment-794951035


   Like this: https://github.com/apache/superset/pull/13498 ? 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] mayurnewase closed issue #13522: [documentation]: updating db migration in contribution file

Posted by GitBox <gi...@apache.org>.
mayurnewase closed issue #13522:
URL: https://github.com/apache/superset/issues/13522


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org