You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/04/24 09:38:39 UTC

[GitHub] [thrift] zeshuai007 opened a new pull request #2089: Supplementary testcase for py module 

zeshuai007 opened a new pull request #2089:
URL: https://github.com/apache/thrift/pull/2089


   <!-- Explain the changes in the pull request below: -->
     
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [ ] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, add ` [skip ci]` at the end of your pull request to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] zeshuai007 commented on pull request #2089: Supplementary testcase for py module

Posted by GitBox <gi...@apache.org>.
zeshuai007 commented on pull request #2089:
URL: https://github.com/apache/thrift/pull/2089#issuecomment-618908962


   hi, @dcelasun 
   I have modified it locally and can resubmit this PR.  can you reopen this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on a change in pull request #2089: Supplementary testcase for py module

Posted by GitBox <gi...@apache.org>.
Jens-G commented on a change in pull request #2089:
URL: https://github.com/apache/thrift/pull/2089#discussion_r415288133



##########
File path: lib/py/test/thrift_transport.py
##########
@@ -0,0 +1,51 @@
+import unittest

Review comment:
       ASF header missing




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] dcelasun commented on pull request #2089: Supplementary testcase for py module

Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2089:
URL: https://github.com/apache/thrift/pull/2089#issuecomment-620406020


   LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] zeshuai007 commented on pull request #2089: Supplementary testcase for py module

Posted by GitBox <gi...@apache.org>.
zeshuai007 commented on pull request #2089:
URL: https://github.com/apache/thrift/pull/2089#issuecomment-620313964


   @Jens-G
    I have fixed the conflict, and the CI has passed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] zeshuai007 edited a comment on pull request #2089: Supplementary testcase for py module

Posted by GitBox <gi...@apache.org>.
zeshuai007 edited a comment on pull request #2089:
URL: https://github.com/apache/thrift/pull/2089#issuecomment-620313964


   @Jens-G， @dcelasun ,
    I have fixed the conflict, and the CI has passed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] dcelasun commented on pull request #2089: Supplementary testcase for py module

Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2089:
URL: https://github.com/apache/thrift/pull/2089#issuecomment-618676340


   This broke [CI](https://api.travis-ci.org/v3/job/672411817/log.txt) due to style issues.
   
   Please ping me after fixing and I'll reopen.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org