You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/11/05 03:44:20 UTC

Review Request 15226: Added a performance test for the Registrar.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15226/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Repository: mesos-git


Description
-------

This is a performance test on 10,000 slaves that I've added for the Registrar.

The Registrar is quite slow primarily due to the amount of copying we do of the registry::Slaves protobuf. I have an upcoming patch that drastically improves performance from O(minutes) to O(seconds) for the test by eliminating a lot of the protobuf copying operations.

For a table of results:
https://docs.google.com/spreadsheet/ccc?key=0AnnSrLSlZqZKdER2djhuRFp5TU5KekVIaC1qcGp4clE&usp=sharing


Diffs
-----

  src/tests/registrar_tests.cpp 51975f5aa2725f64d2a83387a381e5078c8b9e1d 

Diff: https://reviews.apache.org/r/15226/diff/


Testing
-------

make check.

Leaving this test as DISABLED_, but ideally we can come up with a good strategy for adding benchmarks.


Thanks,

Ben Mahler

Re: Review Request 15226: Added a performance test for the Registrar.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15226/
-----------------------------------------------------------

(Updated Nov. 7, 2013, 8:58 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Added a log line to show the protobuf size in bytes.


Repository: mesos-git


Description
-------

This is a performance test on 10,000 slaves that I've added for the Registrar.

The Registrar is quite slow primarily due to the amount of copying we do of the registry::Slaves protobuf. I have an upcoming patch that drastically improves performance from O(minutes) to O(seconds) for the test by eliminating a lot of the protobuf copying operations.

For a table of results:
https://docs.google.com/spreadsheet/ccc?key=0AnnSrLSlZqZKdER2djhuRFp5TU5KekVIaC1qcGp4clE&usp=sharing


Diffs (updated)
-----

  src/tests/registrar_tests.cpp 51975f5aa2725f64d2a83387a381e5078c8b9e1d 

Diff: https://reviews.apache.org/r/15226/diff/


Testing
-------

make check.

Leaving this test as DISABLED_, but ideally we can come up with a good strategy for adding benchmarks.


Thanks,

Ben Mahler