[jira] [Commented] (BEAM-1993) Remove special unbounded Flink source/sink

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972780#comment-15972780 ] 

ASF GitHub Bot commented on BEAM-1993:
--------------------------------------

GitHub user iemejia opened a pull request:

    https://github.com/apache/beam/pull/2574

    [BEAM-1993] Remove special unbounded Flink source/sink

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iemejia/beam BEAM-1993-remove-flink-special-source-sink

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2574.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2574
    
----
commit d8213fa6b274cd6acbf4da6deffd21ca23fd7f42
Author: Ismaël Mejía <ie...@apache.org>
Date:   2017-04-18T14:03:11Z

    [BEAM-1993] Remove special unbounded Flink source/sink

----


> Remove special unbounded Flink source/sink
> ------------------------------------------
>
>                 Key: BEAM-1993
>                 URL: https://issues.apache.org/jira/browse/BEAM-1993
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-flink
>            Reporter: Aljoscha Krettek
>            Assignee: Ismaël Mejía
>             Fix For: First stable release
>
>
> {{UnboundedFlinkSource}} and {{UnboundedFlinkSink}} allow using a Flink {{SourceFunction}}/{{SinkFunction}} with Beam. They only work on the Flink Runner since they directly pass through the function. This doesn't play well with Runner portability and was there in the beginning because Beam didn't yet have a rich ecosystem of connectors.
> Once we remove this we can also remove the flink/examples package because the only custom stuff left there is examples showcasing the use of Flink sources/sinks.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)