You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/09/07 08:42:49 UTC

[GitHub] [hive] abstractdog commented on pull request #3556: HIVE-26500: Improve TestHiveMetastore

abstractdog commented on PR #3556:
URL: https://github.com/apache/hive/pull/3556#issuecomment-1239090642

   > LGTM. Sonar has some complains. https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&pullRequest=3556&id=apache_hive&open=AYMS1ejLkC-HJGhR5irJ
   > 
   > I am not sure how we are handling them..
   
   sonar is absolutely right when saying "Using Thread.sleep in a test is just generally a bad idea.", that's exactly what I fixed with this, but it hasn't realized :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org