You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/10 07:15:49 UTC

[GitHub] [incubator-doris] blackfox1983 commented on a change in pull request #2865: support escape characte

blackfox1983 commented on a change in pull request #2865: support escape characte
URL: https://github.com/apache/incubator-doris/pull/2865#discussion_r376896454
 
 

 ##########
 File path: be/src/exec/es_http_scan_node.cpp
 ##########
 @@ -166,6 +166,11 @@ Status EsHttpScanNode::start_scanners() {
 }
 
 Status EsHttpScanNode::collect_scanners_status() {
+    // NOTE. if open() was called, but set_range() was NOT called for some reason.
 
 Review comment:
   Yes. it's last pr i commited. it was committed failed at that time

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org