You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2021/02/16 21:17:06 UTC
[GitHub] [groovy] eric-milles opened a new pull request #1493: GROOVY-9945: findParameterizedType: fill type parameters of super types
eric-milles opened a new pull request #1493:
URL: https://github.com/apache/groovy/pull/1493
https://issues.apache.org/jira/browse/GROOVY-9945
There is quite a history to `findParameterizedType` and related methods. I did not fully understand the reason for some of the looser checks. I think they were to account for incomplete generics, which are now more complete. Rather then building the whole type hierarchy at once, I took an approach of build as needed. This should reduce some of the cost of searching. I would have reduced the method count further, but it's all public api now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] danielsun1106 merged pull request #1493: GROOVY-9945: findParameterizedType: fill type parameters of super types
Posted by GitBox <gi...@apache.org>.
danielsun1106 merged pull request #1493:
URL: https://github.com/apache/groovy/pull/1493
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] danielsun1106 commented on pull request #1493: GROOVY-9945: findParameterizedType: fill type parameters of super types
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on pull request #1493:
URL: https://github.com/apache/groovy/pull/1493#issuecomment-780773879
Merged. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org