You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mjsax (via GitHub)" <gi...@apache.org> on 2024/03/06 23:32:56 UTC
[PR] KAFKA-15964: fix flaky StreamsAssignmentScaleTest [kafka]
mjsax opened a new pull request, #15485:
URL: https://github.com/apache/kafka/pull/15485
This PR bumps some timeouts due to slow Jenkins builds.
+++
I looked into logs, and it seems that some assignment take up to 90 seconds when they timeout. Also talked to @ableegoldman about the purpose of this test, and it's really about not hitting `max.poll.interval.ms` -- so with a timeout of 2 minutes instead of 1, we still have enough headroom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15964: fix flaky StreamsAssignmentScaleTest [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #15485:
URL: https://github.com/apache/kafka/pull/15485#discussion_r1515287246
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##########
@@ -628,7 +628,7 @@ private boolean assignTasksToClients(final Cluster fullMetadata,
log.info("{} client nodes and {} consumers participating in this rebalance: \n{}.",
clientStates.size(),
- clientStates.values().stream().map(ClientState::capacity).reduce(Integer::sum),
+ clientStates.values().stream().map(ClientState::capacity).reduce(Integer::sum).orElse(0),
Review Comment:
Minor fix: It's an `Optional` and the log currently say:
```
5 client nodes and Optional[10] consumers participating in this rebalance
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15964: fix flaky StreamsAssignmentScaleTest [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #15485:
URL: https://github.com/apache/kafka/pull/15485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org