You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/05/24 23:37:48 UTC
Review Request 59557: Windows: Bumped required CMake version to 3.8.1.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59557/
-----------------------------------------------------------
Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
Bugs: MESOS-7351
https://issues.apache.org/jira/browse/MESOS-7351
Repository: mesos
Description
-------
The 3.7.x series has a bug where it cannot find Visual Studio 2017
tools. See https://gitlab.kitware.com/cmake/cmake/issues/16732
Diffs
-----
CMakeLists.txt 4ba6dd04ad594b0087784d12b785894d9ae257ac
Diff: https://reviews.apache.org/r/59557/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 59557: Windows: Bumped required CMake version to
3.8.1.
Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59557/#review176022
-----------------------------------------------------------
Ship it!
Ship It!
- Jeff Coffler
On May 24, 2017, 11:37 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59557/
> -----------------------------------------------------------
>
> (Updated May 24, 2017, 11:37 p.m.)
>
>
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-7351
> https://issues.apache.org/jira/browse/MESOS-7351
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The 3.7.x series has a bug where it cannot find Visual Studio 2017
> tools. See https://gitlab.kitware.com/cmake/cmake/issues/16732
>
>
> Diffs
> -----
>
> CMakeLists.txt 4ba6dd04ad594b0087784d12b785894d9ae257ac
>
>
> Diff: https://reviews.apache.org/r/59557/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 59557: Windows: Bumped required CMake version to
3.8.1.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59557/#review176124
-----------------------------------------------------------
Ship it!
There's no particular reason to require `3.8.1` instead of `3.8.0` (see patch notes: https://blog.kitware.com/cmake-3-8-1-available-for-download/ ). We use features from `3.8`, but not from the patch release.
(As discussed offline, I'll lower the requirement before committing.)
- Joseph Wu
On May 24, 2017, 4:37 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59557/
> -----------------------------------------------------------
>
> (Updated May 24, 2017, 4:37 p.m.)
>
>
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-7351
> https://issues.apache.org/jira/browse/MESOS-7351
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The 3.7.x series has a bug where it cannot find Visual Studio 2017
> tools. See https://gitlab.kitware.com/cmake/cmake/issues/16732
>
>
> Diffs
> -----
>
> CMakeLists.txt 4ba6dd04ad594b0087784d12b785894d9ae257ac
>
>
> Diff: https://reviews.apache.org/r/59557/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>