You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by GitBox <gi...@apache.org> on 2020/06/12 15:38:04 UTC

[GitHub] [ambari] dvitiiuk opened a new pull request #3204: AMBARI-25520. Insecure Transport : Weak SSL Cipher and weak protocol.

dvitiiuk opened a new pull request #3204:
URL: https://github.com/apache/ambari/pull/3204


   ## What changes were proposed in this pull request?
   
   Now it is prohibited to use TLS 1.0 SSL for ambari server.
   
   ## How was this patch tested?
   
   Manual testing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ambari] hapylestat removed a comment on pull request #3204: AMBARI-25520. Insecure Transport : Weak SSL Cipher and weak protocol.

Posted by GitBox <gi...@apache.org>.
hapylestat removed a comment on pull request #3204:
URL: https://github.com/apache/ambari/pull/3204#issuecomment-648128615


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ambari] dvitiiuk commented on a change in pull request #3204: AMBARI-25520. Insecure Transport : Weak SSL Cipher and weak protocol.

Posted by GitBox <gi...@apache.org>.
dvitiiuk commented on a change in pull request #3204:
URL: https://github.com/apache/ambari/pull/3204#discussion_r441052119



##########
File path: ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
##########
@@ -200,6 +200,7 @@
    */
   public static final EnumSet<DispatcherType> DISPATCHER_TYPES = EnumSet.of(DispatcherType.REQUEST);
   private static final int DEFAULT_ACCEPTORS_COUNT = 1;
+  private static final String[] DEPRECATED_SSL_PROTOCOLS = new String[] {"TLSv1"};

Review comment:
       The such deprecation list is already implemented with "security.server.disabled.protocols" property.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ambari] virajjasani commented on a change in pull request #3204: AMBARI-25520. Insecure Transport : Weak SSL Cipher and weak protocol.

Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #3204:
URL: https://github.com/apache/ambari/pull/3204#discussion_r439753658



##########
File path: ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
##########
@@ -200,6 +200,7 @@
    */
   public static final EnumSet<DispatcherType> DISPATCHER_TYPES = EnumSet.of(DispatcherType.REQUEST);
   private static final int DEFAULT_ACCEPTORS_COUNT = 1;
+  private static final String[] DEPRECATED_SSL_PROTOCOLS = new String[] {"TLSv1"};

Review comment:
       Can this be made configurable in `ambari.properties` such that user can also define their exclude list on top of this deprecated list?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ambari] hapylestat merged pull request #3204: AMBARI-25520. Insecure Transport : Weak SSL Cipher and weak protocol.

Posted by GitBox <gi...@apache.org>.
hapylestat merged pull request #3204:
URL: https://github.com/apache/ambari/pull/3204


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ambari] hapylestat commented on pull request #3204: AMBARI-25520. Insecure Transport : Weak SSL Cipher and weak protocol.

Posted by GitBox <gi...@apache.org>.
hapylestat commented on pull request #3204:
URL: https://github.com/apache/ambari/pull/3204#issuecomment-648128615


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ambari] hapylestat removed a comment on pull request #3204: AMBARI-25520. Insecure Transport : Weak SSL Cipher and weak protocol.

Posted by GitBox <gi...@apache.org>.
hapylestat removed a comment on pull request #3204:
URL: https://github.com/apache/ambari/pull/3204#issuecomment-648269823


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ambari] hapylestat commented on pull request #3204: AMBARI-25520. Insecure Transport : Weak SSL Cipher and weak protocol.

Posted by GitBox <gi...@apache.org>.
hapylestat commented on pull request #3204:
URL: https://github.com/apache/ambari/pull/3204#issuecomment-648269823


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org