[jira] [Comment Edited] (MNGSITE-455) Maven should not attempt to download the jar when pom

["Marcono1234 (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNGSITE-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464867#comment-17464867 ] 

Marcono1234 edited comment on MNGSITE-455 at 12/24/21, 2:28 AM:
----------------------------------------------------------------

Maybe part of the misunderstand here is also that for missing relocation elements (e.g. here {{version}}) the value of the current project is used. That is mentioned in the Maven project descriptor reference (e.g. https://maven.apache.org/ref/3.8.4/maven-model/maven.html#class_relocation), which is linked from the relocation guide, but it might be good to explicitly mention it in the relocation guide, together with the information that the relocation coordinates should point to an existing artifact.


was (Author: marcono1234):
The relocation guide seems to be correct. For recent Maven versions (e.g. 3.8.2), the relocation POM appears to suffice. For me Maven is properly following your relocation POM and downloads the artifact from the new coordinates.

[~TheSnoozer], are you maybe using an older Maven version? MNG-3762 suggests that older versions did not properly follow relocation POMs for plugins.

> Maven should not attempt to download the jar when <packaging>pom</packaging>
> ----------------------------------------------------------------------------
>
>                 Key: MNGSITE-455
>                 URL: https://issues.apache.org/jira/browse/MNGSITE-455
>             Project: Maven Project Web Site
>          Issue Type: Improvement
>            Reporter: S L
>            Priority: Major
>
> Hello,
> maybe a corner case of what exactly should be part of a "relocation pom" ([https://maven.apache.org/guides/mini/guide-relocation.html]), but I created a release just consisting of the relocation-info ([https://repo1.maven.org/maven2/pl/project13/maven/git-commit-id-plugin/4.9.9/git-commit-id-plugin-4.9.9.pom]) as type `<packaging>pom</packaging>` (since I only wanted to publish the relocation information).
> Using this depdendency.e.g. via:
> {code}
> <build>
>   <plugins>
>     <plugin>
>       <groupId>pl.project13.maven</groupId>
>       <artifactId>git-commit-id-plugin</artifactId>
>       <version>4.9.9</version>
>     </plugin>
>   </plugins>
> </build>
> {code}
> yields in the incorrect attempt of downloading a JAR-File from the new repository location:
> {code}
> [INFO] Building Git Commit Id Plugin Maven Mojo Debugging 0.0.3-SNAPSHOT  [1/3]
> [INFO] --------------------------------[ pom ]---------------------------------
> Downloading from central-secure: https://repo.maven.apache.org/maven2/io/github/git-commit-id/git-commit-id-maven-plugin/4.9.9/git-commit-id-maven-plugin-4.9.9.pom
> [WARNING] The POM for io.github.git-commit-id:git-commit-id-maven-plugin:jar:4.9.9 is missing, no dependency information available
> Downloading from central-secure: https://repo.maven.apache.org/maven2/io/github/git-commit-id/git-commit-id-maven-plugin/4.9.9/git-commit-id-maven-plugin-4.9.9.jar
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary for Git Commit Id Plugin Maven Mojo Debugging 0.0.3-SNAPSHOT:
> [INFO] 
> [INFO] Git Commit Id Plugin Maven Mojo Debugging .......... FAILURE [  0.850 s]
> [INFO] submodule-one ...................................... SKIPPED
> [INFO] submodule-two ...................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time:  1.000 s
> [INFO] Finished at: 2021-07-12T21:42:15+02:00
> [INFO] ------------------------------------------------------------------------
> [ERROR] Plugin pl.project13.maven:git-commit-id-plugin:4.9.9 or one of its dependencies could not be resolved: Could not find artifact io.github.git-commit-id:git-commit-id-maven-plugin:jar:4.9.9 in central-secure (https://repo.maven.apache.org/maven2) -> [Help 1]
>  {code}
> IMHO Maven should not even try to search for a jar when `<packaging>pom</packaging>`. Simply raise an error that the package was relocated. the new location is at least detected, since it tries to download the artifact from a new location.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)