[jira] [Commented] (YUNIKORN-178) Remove call to get config from the admission controller

["Weiwei Yang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116349#comment-17116349 ] 

Weiwei Yang commented on YUNIKORN-178:
--------------------------------------

Hi [~wilfreds]

I think we can hard code the scheduler name to \{{yunikorn}}. 

Spent more efforts to make it configurable won't give us any benefit. I don't think users will configure this to something else. Is that OK with you?

> Remove call to get config from the admission controller
> -------------------------------------------------------
>
>                 Key: YUNIKORN-178
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-178
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: shim - kubernetes
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Ting Yao,Huang
>            Priority: Minor
>              Labels: newbie
>
> The admission controller does not have a possibility to process configuration from anywhere.
> However it does try to retrieve the scheduler name in by calling {{conf.GetSchedulerConf().SchedulerName}} in \{{updateSchedulerName}}. This will not work and should be replaced by a environment setting like what was done in YUNIKORN-28 for other values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org