You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yzhou2001 <gi...@git.apache.org> on 2015/12/23 18:31:13 UTC

[GitHub] spark pull request: [SPARK-10838][SPARK-11576][SQL] Incorrect resu...

GitHub user yzhou2001 opened a pull request:

    https://github.com/apache/spark/pull/10450

    [SPARK-10838][SPARK-11576][SQL] Incorrect results or exceptions when using self-joins

    I believe the issue is that the mapping between the columns in the join condition and those in the right relation is broken when the right relation has to be regenerated if the conflicting attributes are present.
    The fix is to adjust the column mappings in the join condition if necessary.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yzhou2001/spark fix_of_Spark-10838_and_11576

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/10450.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10450
    
----
commit 41311faf74d0d7e46e8fe1075b4ae87b4c40d82a
Author: yzhou2001 <yz...@yahoo.com>
Date:   2015-12-23T17:08:34Z

    fix for Spark-10838/11576

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10838][SPARK-11576][SQL] Incorrect resu...

Posted by yzhou2001 <gi...@git.apache.org>.
Github user yzhou2001 closed the pull request at:

    https://github.com/apache/spark/pull/10450


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10838][SPARK-11576][SQL] Incorrect resu...

Posted by yzhou2001 <gi...@git.apache.org>.
Github user yzhou2001 commented on the pull request:

    https://github.com/apache/spark/pull/10450#issuecomment-166974291
  
    This change is actually very close to https://github.com/apache/spark/pull/9548. Sorry I did not look at the code changes carefully there, except for the detailed explanations, before submit this PR. So I am closing this now and will think more on the issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10838][SPARK-11576][SQL] Incorrect resu...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/10450#issuecomment-166950936
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org