You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by gg...@apache.org on 2020/11/24 14:22:43 UTC

[httpcomponents-client] 06/06: Remove redundant returns.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-client.git

commit 75f9adea87cb5310229e8e2c0db15161343bf11c
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Nov 23 12:14:22 2020 -0500

    Remove redundant returns.
---
 .../main/java/org/apache/hc/client5/http/impl/win/WinHttpClients.java | 4 ++--
 .../java/org/apache/hc/client5/http/impl/auth/BasicAuthCache.java     | 2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/httpclient5-win/src/main/java/org/apache/hc/client5/http/impl/win/WinHttpClients.java b/httpclient5-win/src/main/java/org/apache/hc/client5/http/impl/win/WinHttpClients.java
index 47f3274..105005e 100644
--- a/httpclient5-win/src/main/java/org/apache/hc/client5/http/impl/win/WinHttpClients.java
+++ b/httpclient5-win/src/main/java/org/apache/hc/client5/http/impl/win/WinHttpClients.java
@@ -57,8 +57,8 @@ public class WinHttpClients {
         if (os != null && os.contains("windows")) {
             try {
                 return Sspi.MAX_TOKEN_SIZE > 0;
-            } catch (final Exception ignore) { // Likely ClassNotFound
-                return false;
+            } catch (final Exception ignore) {
+                // Likely ClassNotFound
             }
         }
         return false;
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/BasicAuthCache.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/BasicAuthCache.java
index 2a6f1a2..c22c57b 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/BasicAuthCache.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/BasicAuthCache.java
@@ -121,12 +121,10 @@ public class BasicAuthCache implements AuthCache {
                 if (LOG.isWarnEnabled()) {
                     LOG.warn("Unexpected I/O error while de-serializing auth scheme", ex);
                 }
-                return null;
             } catch (final ClassNotFoundException ex) {
                 if (LOG.isWarnEnabled()) {
                     LOG.warn("Unexpected error while de-serializing auth scheme", ex);
                 }
-                return null;
             }
         }
         return null;