You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "nickva (via GitHub)" <gi...@apache.org> on 2023/05/25 03:54:32 UTC

[GitHub] [couchdb] nickva opened a new pull request, #4623: Handle replicator instance start time during upgrades better

nickva opened a new pull request, #4623:
URL: https://github.com/apache/couchdb/pull/4623

   During cluster upgrades from 3.2 to 3.3 when instance start time switched from being always  `0` to an actual timestamp, replication jobs will crash when endpoints are upgraded. Replication jobs were started when endpoint emitted a `0` and then it becomes a non-`0` value which will crash the next checkpoint attempt.
   
   After the crash jobs will restart and continue fine were they left off without rewinding. However they will make a logging mess while they crash. All four workers will exit the `{checkpoint_commit_failure,...}` error. This commit make it the checkpoint ignore mismatches if one of the instance start times is 0.
   
   Issue: https://github.com/apache/couchdb/issues/4621


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] nickva merged pull request #4623: Handle replicator instance start time during upgrades better

Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva merged PR #4623:
URL: https://github.com/apache/couchdb/pull/4623


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] nickva commented on pull request #4623: Handle replicator instance start time during upgrades better

Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #4623:
URL: https://github.com/apache/couchdb/pull/4623#issuecomment-1563370554

   @big-r81 good idea, I thought it looked a bit smaller and better with shorter variables it's not a lot better. Reverted back to original names. Also added a comment indicated what is happening with the `<<"0">>` check there and why we're doing it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org