[GitHub] [avro] meni-braun opened a new pull request #1298: Memory optimization in SchemaName.Fullname

[GitBox <gi...@apache.org>]

meni-braun opened a new pull request #1298:
URL: https://github.com/apache/avro/pull/1298


   FullName property is being called by `ClassCache.GetClass` for each property:
   ```csharp
   public DotnetClass GetClass(RecordSchema schema)
   {
   	DotnetClass result;
   	if (!this._nameClassMap.TryGetValue(schema.Fullname, ref result))
   .
   .
   ```
   
   This allocates TONS of strings on a scenario which calls `Avro.Reflect.ReflectDefaultWriter.WriteRecord` on large amount of entities (millions) + large amount of fields (tens).
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] dkulp merged pull request #1298: Memory optimization in SchemaName.Fullname

[GitBox <gi...@apache.org>]

dkulp merged pull request #1298:
URL: https://github.com/apache/avro/pull/1298


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org