You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@avro.apache.org by "Jeremy Kahn (JIRA)" <ji...@apache.org> on 2013/04/20 03:04:13 UTC

[jira] [Commented] (AVRO-1304) Python Avro match_schemas called redundantly

    [ https://issues.apache.org/jira/browse/AVRO-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637061#comment-13637061 ] 

Jeremy Kahn commented on AVRO-1304:
-----------------------------------

This would be super useful to fix. Do you have a patch prepared?
                
> Python Avro match_schemas called redundantly
> --------------------------------------------
>
>                 Key: AVRO-1304
>                 URL: https://issues.apache.org/jira/browse/AVRO-1304
>             Project: Avro
>          Issue Type: Bug
>          Components: python
>    Affects Versions: 1.7.4
>            Reporter: Uri Laserson
>
> DatumReader.match_schemas(writers_schema, readers_schema) is called on every single read from the DatumReader.  However, for almost every read, the schemas used are the object members self.writers_schema and self.readers_schema.  match_schemas should be checked only once in this case, and only when the object members are modified.  This takes up 20% of my parse time upon profiling.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira