You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ki...@apache.org on 2017/05/01 09:48:44 UTC
[1/4] [lang] Increase test coverage of ToStringBuilder class to 100%
Repository: commons-lang
Updated Branches:
refs/heads/master 610caab59 -> 88da5f49b
Increase test coverage of ToStringBuilder class to 100%
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/ece2f255
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/ece2f255
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/ece2f255
Branch: refs/heads/master
Commit: ece2f255eed8ad9eff6e236152de65e804c6adb5
Parents: 331d2f2
Author: Basha <ar...@paypalcorp.com>
Authored: Sat Apr 29 18:11:13 2017 +0530
Committer: Basha <ar...@paypalcorp.com>
Committed: Sat Apr 29 19:22:59 2017 +0530
----------------------------------------------------------------------
.../lang3/builder/ToStringBuilderTest.java | 225 +++++++++++++++++++
1 file changed, 225 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/ece2f255/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java b/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java
index eba610a..b218329 100644
--- a/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java
+++ b/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java
@@ -615,6 +615,231 @@ public class ToStringBuilderTest {
}
@Test
+ public void testAppendAsObjectToString() {
+ String objectToAppend1 = "";
+ Boolean objectToAppend2 = Boolean.TRUE;
+ Object objectToAppend3 = new Object();
+
+ assertEquals(baseStr + "[" + toBaseString(objectToAppend1) + "]",
+ new ToStringBuilder(base).appendAsObjectToString(objectToAppend1).toString());
+ assertEquals(baseStr + "[" + toBaseString(objectToAppend2) + "]",
+ new ToStringBuilder(base).appendAsObjectToString(objectToAppend2).toString());
+ assertEquals(baseStr + "[" + toBaseString(objectToAppend3) + "]",
+ new ToStringBuilder(base).appendAsObjectToString(objectToAppend3).toString());
+ }
+
+ @Test
+ public void testAppendBooleanArrayWithFieldName() {
+ boolean[] array = new boolean[] { true, false, false };
+ assertEquals(baseStr + "[flags={true,false,false}]",
+ new ToStringBuilder(base).append("flags", array).toString());
+ assertEquals(baseStr + "[flags=<null>]",
+ new ToStringBuilder(base).append("flags", (boolean[]) null).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null).toString());
+ assertEquals(baseStr + "[{true,false,false}]", new ToStringBuilder(base).append(null, array).toString());
+ }
+
+ @Test
+ public void testAppendBooleanArrayWithFieldNameAndFullDetatil() {
+ boolean[] array = new boolean[] { true, false, false };
+ assertEquals(baseStr + "[flags={true,false,false}]",
+ new ToStringBuilder(base).append("flags", array, true).toString());
+ assertEquals(baseStr + "[length=<size=3>]",
+ new ToStringBuilder(base).append("length", array, false).toString());
+ assertEquals(baseStr + "[flags=<null>]",
+ new ToStringBuilder(base).append("flags", (boolean[]) null, true).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null, false).toString());
+ assertEquals(baseStr + "[<size=3>]", new ToStringBuilder(base).append(null, array, false).toString());
+ }
+
+ @Test
+ public void testAppendCharArrayWithFieldName() {
+ char[] array = new char[] { 'A', '2', '_', 'D' };
+ assertEquals(baseStr + "[chars={A,2,_,D}]", new ToStringBuilder(base).append("chars", array).toString());
+ assertEquals(baseStr + "[letters={A,2,_,D}]", new ToStringBuilder(base).append("letters", array).toString());
+ assertEquals(baseStr + "[flags=<null>]",
+ new ToStringBuilder(base).append("flags", (boolean[]) null).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null).toString());
+ assertEquals(baseStr + "[{A,2,_,D}]", new ToStringBuilder(base).append(null, array).toString());
+ }
+
+ @Test
+ public void testAppendCharArrayWithFieldNameAndFullDetatil() {
+ char[] array = new char[] { 'A', '2', '_', 'D' };
+ assertEquals(baseStr + "[chars={A,2,_,D}]", new ToStringBuilder(base).append("chars", array, true).toString());
+ assertEquals(baseStr + "[letters=<size=4>]",
+ new ToStringBuilder(base).append("letters", array, false).toString());
+ assertEquals(baseStr + "[flags=<null>]",
+ new ToStringBuilder(base).append("flags", (boolean[]) null, true).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null, false).toString());
+ assertEquals(baseStr + "[<size=4>]", new ToStringBuilder(base).append(null, array, false).toString());
+ }
+
+ @Test
+ public void testAppendDoubleArrayWithFieldName() {
+ double[] array = new double[] { 1.0, 2.9876, -3.00001, 4.3 };
+ assertEquals(baseStr + "[values={1.0,2.9876,-3.00001,4.3}]",
+ new ToStringBuilder(base).append("values", array).toString());
+ assertEquals(baseStr + "[values=<null>]",
+ new ToStringBuilder(base).append("values", (boolean[]) null).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null).toString());
+ assertEquals(baseStr + "[{1.0,2.9876,-3.00001,4.3}]", new ToStringBuilder(base).append(null, array).toString());
+ }
+
+ @Test
+ public void testAppendDoubleArrayWithFieldNameAndFullDetatil() {
+ double[] array = new double[] { 1.0, 2.9876, -3.00001, 4.3 };
+ assertEquals(baseStr + "[values={1.0,2.9876,-3.00001,4.3}]",
+ new ToStringBuilder(base).append("values", array, true).toString());
+ assertEquals(baseStr + "[length=<size=4>]",
+ new ToStringBuilder(base).append("length", array, false).toString());
+ assertEquals(baseStr + "[values=<null>]",
+ new ToStringBuilder(base).append("values", (boolean[]) null, true).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null, false).toString());
+ assertEquals(baseStr + "[<size=4>]", new ToStringBuilder(base).append(null, array, false).toString());
+ }
+
+ @Test
+ public void testAppendObjectArrayWithFieldName() {
+ Object[] array = new Object[] { null, base, new int[] { 3, 6 } };
+ assertEquals(baseStr + "[values={<null>,5,{3,6}}]",
+ new ToStringBuilder(base).append("values", array).toString());
+ assertEquals(baseStr + "[values=<null>]",
+ new ToStringBuilder(base).append("values", (boolean[]) null).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null).toString());
+ assertEquals(baseStr + "[{<null>,5,{3,6}}]", new ToStringBuilder(base).append(null, array).toString());
+ }
+
+ @Test
+ public void testAppendObjectArrayWithFieldNameAndFullDetatil() {
+ Object[] array = new Object[] { null, base, new int[] { 3, 6 } };
+ assertEquals(baseStr + "[values={<null>,5,{3,6}}]",
+ new ToStringBuilder(base).append("values", array, true).toString());
+ assertEquals(baseStr + "[length=<size=3>]",
+ new ToStringBuilder(base).append("length", array, false).toString());
+ assertEquals(baseStr + "[values=<null>]",
+ new ToStringBuilder(base).append("values", (boolean[]) null, true).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null, false).toString());
+ assertEquals(baseStr + "[<size=3>]", new ToStringBuilder(base).append(null, array, false).toString());
+ }
+
+ @Test
+ public void testAppendLongArrayWithFieldName() {
+ long[] array = new long[] { 1, 2, -3, 4 };
+ assertEquals(baseStr + "[values={1,2,-3,4}]", new ToStringBuilder(base).append("values", array).toString());
+ assertEquals(baseStr + "[values=<null>]",
+ new ToStringBuilder(base).append("values", (boolean[]) null).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null).toString());
+ assertEquals(baseStr + "[{1,2,-3,4}]", new ToStringBuilder(base).append(null, array).toString());
+ }
+
+ @Test
+ public void testAppendLongArrayWithFieldNameAndFullDetatil() {
+ long[] array = new long[] { 1, 2, -3, 4 };
+ assertEquals(baseStr + "[values={1,2,-3,4}]",
+ new ToStringBuilder(base).append("values", array, true).toString());
+ assertEquals(baseStr + "[length=<size=4>]",
+ new ToStringBuilder(base).append("length", array, false).toString());
+ assertEquals(baseStr + "[values=<null>]",
+ new ToStringBuilder(base).append("values", (boolean[]) null, true).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null, false).toString());
+ assertEquals(baseStr + "[<size=4>]", new ToStringBuilder(base).append(null, array, false).toString());
+ }
+
+ @Test
+ public void testAppendIntArrayWithFieldName() {
+ int[] array = new int[] { 1, 2, -3, 4 };
+ assertEquals(baseStr + "[values={1,2,-3,4}]", new ToStringBuilder(base).append("values", array).toString());
+ assertEquals(baseStr + "[values=<null>]",
+ new ToStringBuilder(base).append("values", (boolean[]) null).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null).toString());
+ assertEquals(baseStr + "[{1,2,-3,4}]", new ToStringBuilder(base).append(null, array).toString());
+ }
+
+ @Test
+ public void testAppendIntArrayWithFieldNameAndFullDetatil() {
+ int[] array = new int[] { 1, 2, -3, 4 };
+ assertEquals(baseStr + "[values={1,2,-3,4}]",
+ new ToStringBuilder(base).append("values", array, true).toString());
+ assertEquals(baseStr + "[length=<size=4>]",
+ new ToStringBuilder(base).append("length", array, false).toString());
+ assertEquals(baseStr + "[values=<null>]",
+ new ToStringBuilder(base).append("values", (boolean[]) null, true).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null, false).toString());
+ assertEquals(baseStr + "[<size=4>]", new ToStringBuilder(base).append(null, array, false).toString());
+ }
+
+ @Test
+ public void testAppendShortArrayWithFieldName() {
+ short[] array = new short[] { 1, 2, -3, 4 };
+ assertEquals(baseStr + "[values={1,2,-3,4}]", new ToStringBuilder(base).append("values", array).toString());
+ assertEquals(baseStr + "[values=<null>]",
+ new ToStringBuilder(base).append("values", (boolean[]) null).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null).toString());
+ assertEquals(baseStr + "[{1,2,-3,4}]", new ToStringBuilder(base).append(null, array).toString());
+ }
+
+ @Test
+ public void testAppendShortArrayWithFieldNameAndFullDetatil() {
+ short[] array = new short[] { 1, 2, -3, 4 };
+ assertEquals(baseStr + "[values={1,2,-3,4}]",
+ new ToStringBuilder(base).append("values", array, true).toString());
+ assertEquals(baseStr + "[length=<size=4>]",
+ new ToStringBuilder(base).append("length", array, false).toString());
+ assertEquals(baseStr + "[values=<null>]",
+ new ToStringBuilder(base).append("values", (boolean[]) null, true).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null, false).toString());
+ assertEquals(baseStr + "[<size=4>]", new ToStringBuilder(base).append(null, array, false).toString());
+ }
+
+ @Test
+ public void testAppendByteArrayWithFieldName() {
+ byte[] array = new byte[] { 1, 2, -3, 4 };
+ assertEquals(baseStr + "[values={1,2,-3,4}]", new ToStringBuilder(base).append("values", array).toString());
+ assertEquals(baseStr + "[values=<null>]",
+ new ToStringBuilder(base).append("values", (boolean[]) null).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null).toString());
+ assertEquals(baseStr + "[{1,2,-3,4}]", new ToStringBuilder(base).append(null, array).toString());
+ }
+
+ @Test
+ public void testAppendByteArrayWithFieldNameAndFullDetatil() {
+ byte[] array = new byte[] { 1, 2, -3, 4 };
+ assertEquals(baseStr + "[values={1,2,-3,4}]",
+ new ToStringBuilder(base).append("values", array, true).toString());
+ assertEquals(baseStr + "[length=<size=4>]",
+ new ToStringBuilder(base).append("length", array, false).toString());
+ assertEquals(baseStr + "[values=<null>]",
+ new ToStringBuilder(base).append("values", (boolean[]) null, true).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null, false).toString());
+ assertEquals(baseStr + "[<size=4>]", new ToStringBuilder(base).append(null, array, false).toString());
+ }
+
+ @Test
+ public void testAppendFloatArrayWithFieldName() {
+ float[] array = new float[] { 1.0f, 2.9876f, -3.00001f, 4.3f };
+ assertEquals(baseStr + "[values={1.0,2.9876,-3.00001,4.3}]",
+ new ToStringBuilder(base).append("values", array).toString());
+ assertEquals(baseStr + "[values=<null>]",
+ new ToStringBuilder(base).append("values", (boolean[]) null).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null).toString());
+ assertEquals(baseStr + "[{1.0,2.9876,-3.00001,4.3}]", new ToStringBuilder(base).append(null, array).toString());
+ }
+
+ @Test
+ public void testAppendFloatArrayWithFieldNameAndFullDetatil() {
+ float[] array = new float[] { 1.0f, 2.9876f, -3.00001f, 4.3f };
+ assertEquals(baseStr + "[values={1.0,2.9876,-3.00001,4.3}]",
+ new ToStringBuilder(base).append("values", array, true).toString());
+ assertEquals(baseStr + "[length=<size=4>]",
+ new ToStringBuilder(base).append("length", array, false).toString());
+ assertEquals(baseStr + "[values=<null>]",
+ new ToStringBuilder(base).append("values", (boolean[]) null, true).toString());
+ assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null, false).toString());
+ assertEquals(baseStr + "[<size=4>]", new ToStringBuilder(base).append(null, array, false).toString());
+ }
+
+ @Test
public void testObject() {
final Integer i3 = Integer.valueOf(3);
final Integer i4 = Integer.valueOf(4);
[4/4] [lang] LANG-1325: update changes.xml
Posted by ki...@apache.org.
LANG-1325: update changes.xml
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/88da5f49
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/88da5f49
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/88da5f49
Branch: refs/heads/master
Commit: 88da5f49bcaf798712274d60d378ddaebfaa20c2
Parents: af32371
Author: Bruno P. Kinoshita <ki...@apache.org>
Authored: Mon May 1 21:48:04 2017 +1200
Committer: Bruno P. Kinoshita <ki...@apache.org>
Committed: Mon May 1 21:48:04 2017 +1200
----------------------------------------------------------------------
src/changes/changes.xml | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/88da5f49/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 6c3957a..dc6b795 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -46,6 +46,7 @@ The <action> type attribute can be add,update,fix,remove.
<body>
<release version="3.6" date="2017-MM-DD" description="TBD">
+ <action issue="LANG-1325" type="add" dev="kinow" due-to="Arshad Basha">Increase test coverage of ToStringBuilder class to 100%</action>
<action issue="LANG-1307" type="add" dev="pschumacher" due-to="Arshad Basha">Add a method in StringUtils to extract only digits out of input string</action>
<action issue="LANG-1110" type="update" dev="pschumacher" due-to="Bruno P. Kinoshita">Implement HashSetvBitSetTest using JMH</action>
<action issue="LANG-1256" type="add" dev="pschumacher" due-to="C0rWin">Add JMH maven dependencies</action>
[3/4] [lang] Merge branch 'pr/265'
Posted by ki...@apache.org.
Merge branch 'pr/265'
This closes #265
Thanks
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/af323712
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/af323712
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/af323712
Branch: refs/heads/master
Commit: af323712479ba1e2a5b8e519030d021915228c48
Parents: 610caab 9766e22
Author: Bruno P. Kinoshita <ki...@apache.org>
Authored: Mon May 1 21:45:25 2017 +1200
Committer: Bruno P. Kinoshita <ki...@apache.org>
Committed: Mon May 1 21:45:25 2017 +1200
----------------------------------------------------------------------
.../lang3/builder/ToStringBuilderTest.java | 239 +++++++++++++++++++
1 file changed, 239 insertions(+)
----------------------------------------------------------------------
[2/4] [lang] Adding testcase to cover a missing branch.
Posted by ki...@apache.org.
Adding testcase to cover a missing branch.
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/9766e22b
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/9766e22b
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/9766e22b
Branch: refs/heads/master
Commit: 9766e22b42b7b3f3923cb9c2502dfc2dd5d0a5b0
Parents: ece2f25
Author: Basha <ar...@paypalcorp.com>
Authored: Sat Apr 29 20:05:58 2017 +0530
Committer: Basha <ar...@paypalcorp.com>
Committed: Sat Apr 29 20:06:31 2017 +0530
----------------------------------------------------------------------
.../commons/lang3/builder/ToStringBuilderTest.java | 14 ++++++++++++++
1 file changed, 14 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/9766e22b/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java b/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java
index b218329..8e32287 100644
--- a/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java
+++ b/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java
@@ -17,6 +17,7 @@
package org.apache.commons.lang3.builder;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertSame;
import static org.junit.Assume.assumeFalse;
@@ -838,6 +839,19 @@ public class ToStringBuilderTest {
assertEquals(baseStr + "[<null>]", new ToStringBuilder(base).append(null, (boolean[]) null, false).toString());
assertEquals(baseStr + "[<size=4>]", new ToStringBuilder(base).append(null, array, false).toString());
}
+
+ @Test
+ public void testConstructToStringBuilder(){
+ ToStringBuilder stringBuilder1 = new ToStringBuilder(base, null, null);
+ ToStringBuilder stringBuilder2 = new ToStringBuilder(base, ToStringStyle.DEFAULT_STYLE, new StringBuffer(1024));
+ assertEquals(ToStringStyle.DEFAULT_STYLE, stringBuilder1.getStyle());
+ assertNotNull(stringBuilder1.getStringBuffer());
+ assertNotNull(stringBuilder1.toString());
+ assertEquals(ToStringStyle.DEFAULT_STYLE, stringBuilder2.getStyle());
+ assertNotNull(stringBuilder2.getStringBuffer());
+ assertNotNull(stringBuilder2.toString());
+ }
+
@Test
public void testObject() {