You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "ildipo (via GitHub)" <gi...@apache.org> on 2023/05/15 15:50:51 UTC
[GitHub] [arrow] ildipo opened a new pull request, #35592: GH-35539: [C++] remove use of _internal.h header file from public header file
ildipo opened a new pull request, #35592:
URL: https://github.com/apache/arrow/pull/35592
### What changes are included in this PR?
Remove use of compute/util_internal.h in compute/key_map.h
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35592: GH-35539: [C++] Remove use of internal header files from public header file
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35592:
URL: https://github.com/apache/arrow/pull/35592#issuecomment-1549808937
:warning: GitHub issue #35539 **has no components**, please add labels for components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35592: GH-35539: [C++] remove use of _internal.h header file from public header file
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35592:
URL: https://github.com/apache/arrow/pull/35592#issuecomment-1548118267
:warning: GitHub issue #35539 **has no components**, please add labels for components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #35592: GH-35539: [C++] remove use of _internal.h header file from public header file
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #35592:
URL: https://github.com/apache/arrow/pull/35592#issuecomment-1549749734
Thanks @ildipo . I also removed use of `arrow/util/logging.h` which should be avoided in public headers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35592: GH-35539: [C++] Remove use of internal header files from public header file
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35592:
URL: https://github.com/apache/arrow/pull/35592#issuecomment-1554170791
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/fc2ca425cbff47f89f8c025a1920defa...773c34336c5e459cb6d1e133d4e6cb4d/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35592: GH-35539: [C++] Remove use of internal header files from public header file
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35592:
URL: https://github.com/apache/arrow/pull/35592#issuecomment-1554167746
Benchmark runs are scheduled for baseline = af382630b1af55801ab19fbf692bd0130267e853 and contender = 505a2e4519ba8d4983da6caa1c56ecae8d063e84. 505a2e4519ba8d4983da6caa1c56ecae8d063e84 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/3605d7474f614518af3ce77fdbd59168...a21648fbd5044b6e92fe80c5f82bfd62/)
[Finished :arrow_down:1.1% :arrow_up:0.12%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/56138d45720b4cb68e8915cc368c92a0...5a7195618bd44370b72e895523e691c9/)
[Finished :arrow_down:1.02% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/fc2ca425cbff47f89f8c025a1920defa...773c34336c5e459cb6d1e133d4e6cb4d/)
[Finished :arrow_down:0.45% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/7ff69e45b5d0404e958420a2350d82f9...ce6806a4afac4a098a742dc3db1621cd/)
Buildkite builds:
[Finished] [`505a2e45` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2883)
[Finished] [`505a2e45` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2919)
[Finished] [`505a2e45` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2884)
[Finished] [`505a2e45` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2909)
[Finished] [`af382630` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2882)
[Finished] [`af382630` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2918)
[Finished] [`af382630` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2883)
[Finished] [`af382630` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2908)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35592: GH-35539: [C++] remove use of _internal.h header file from public header file
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35592:
URL: https://github.com/apache/arrow/pull/35592#issuecomment-1548118232
:warning: GitHub issue #35539 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35592: GH-35539: [C++] remove use of _internal.h header file from public header file
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35592:
URL: https://github.com/apache/arrow/pull/35592#issuecomment-1548118167
* Closes: #35539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #35592: GH-35539: [C++] Remove use of internal header files from public header file
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #35592:
URL: https://github.com/apache/arrow/pull/35592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org