You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/02/05 19:23:48 UTC

[GitHub] sijie commented on a change in pull request #1165: PIP-13-2/3: support regex based subscription

sijie commented on a change in pull request #1165: PIP-13-2/3: support regex based subscription
URL: https://github.com/apache/incubator-pulsar/pull/1165#discussion_r166083714
 
 

 ##########
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##########
 @@ -458,6 +470,9 @@ message BaseCommand {
 		REACHED_END_OF_TOPIC = 27;
 
 		SEEK = 28;
+
+		GET_TOPICS_OF_NAMESPACE 			= 29;
 
 Review comment:
   If I remembered correctly, we are bumping the protocol version in one of your other pull requests, if this change is going to be merged with that pull request in same release, I would suggest update the comment of that protocol version with these two new commands.
   
   Otherwise, we have to bump the protocol version. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services