[GitHub] [hudi] danny0405 commented on a diff in pull request #8351: [HUDI-6013] Support database name for meta sync in bootstrap

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #8351:
URL: https://github.com/apache/hudi/pull/8351#discussion_r1155501254


##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/RunBootstrapProcedure.scala:
##########
@@ -85,6 +85,7 @@ class RunBootstrapProcedure extends BaseProcedure with ProcedureBuilder with Log
     val propsFilePath = getArgValueOrDefault(args, PARAMETERS(15)).get.asInstanceOf[String]
     val bootstrapOverwrite = getArgValueOrDefault(args, PARAMETERS(16)).get.asInstanceOf[Boolean]
 
+    val (tableName, database) = HoodieCLIUtils.getHoodieDatabaseAndTable(table.get.asInstanceOf[String])
     val configs: util.List[String] = new util.ArrayList[String]

Review Comment:
   Should the database name be a separate param?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org