You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by guoxiaolongzte <gi...@git.apache.org> on 2017/03/30 15:47:03 UTC

[GitHub] spark pull request #17481: [SPARK-20157]In the menu ‘Storage’in Web UI, ...

GitHub user guoxiaolongzte opened a pull request:

    https://github.com/apache/spark/pull/17481

    [SPARK-20157]In the menu \u2018Storage\u2019in Web UI, click the Go button, and\u2026

    \u2026 shows no paging menu interface.
    
    ## What changes were proposed in this pull request?
    
    (Please fill in changes proposed in this fix)
    
    ## How was this patch tested?
    
    (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
    (If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guoxiaolongzte/spark SPARK-20157

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17481.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17481
    
----
commit 5d7407472f48303847ed2d71021546a00b26c48a
Author: guoxiaolongzte <gu...@zte.com.cn>
Date:   2017-03-30T12:25:20Z

    [SPARK-20157]In the menu \u2018Storage\u2019in Web UI, click the Go button, and shows no paging menu interface.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17481: [SPARK-20157]In the menu ‘Storage’in Web UI, click t...

Posted by guoxiaolongzte <gi...@git.apache.org>.

Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17481
  
    @srowen 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17481: [SPARK-20157]In the menu ‘Storage’in Web UI, click t...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17481
  
    **[Test build #3621 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3621/testReport)** for PR 17481 at commit [`5d74074`](https://github.com/apache/spark/commit/5d7407472f48303847ed2d71021546a00b26c48a).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17481: [SPARK-20157]In the menu ‘Storage’in Web UI, click t...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17481
  
    **[Test build #3621 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3621/testReport)** for PR 17481 at commit [`5d74074`](https://github.com/apache/spark/commit/5d7407472f48303847ed2d71021546a00b26c48a).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17481: [SPARK-20157]In the menu ‘Storage’in Web UI, click t...

Posted by ajbozarth <gi...@git.apache.org>.

Github user ajbozarth commented on the issue:

    https://github.com/apache/spark/pull/17481
  
    I actually brought this up with @zsxwing (who designed the paging) in a previous PR and he said this was intentional. The idea is that when a table is too small for paging the paging options shouldn't be shown. This does mean if you expand the table to larger than the total rows the paging options will disappear. Given it can be found again by going "back" in your browser I believe leaving it as designed is better (@zsxwing had to convince me of this during our previous discussion). 
    
    **If** we decide to update this we should do it across all paged tables in the UI not just the storage tab though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17481: [SPARK-20157]In the menu ‘Storage’in Web UI, click t...

Posted by guoxiaolongzte <gi...@git.apache.org>.

Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17481
  
    if you expand the table to equal the total rows the paging options will disappear. This is too unreasonable. For me a large number of data pages show, it is not convenient and reasonable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17481: [SPARK-20157]In the menu ‘Storage’in Web UI, click t...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/17481
  
    I don't see the issue here. If you expand the table such that no paging is needed, why do you need to page? if more rows are added you need to refresh to see them anyway. Going back is the natural thing to do if you really want to get back to the previous view, in this corner case. If it was at all intentional, I'd leave it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17481: [SPARK-20157]In the menu ‘Storage’in Web UI, click t...

Posted by guoxiaolongzte <gi...@git.apache.org>.

Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17481
  
    Please help to code view,thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17481: [SPARK-20157]In the menu ‘Storage’in Web UI, click t...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/17481
  
    I'm sorry I still don't understand the issue.  In your example, you just hit 'back' to go back from an unpaged view to paged. I think this should be closed given feedback.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17481: [SPARK-20157]In the menu ‘Storage’in Web UI, click t...

Posted by guoxiaolongzte <gi...@git.apache.org>.

Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17481
  
    I think this design is not reasonable, because I may need to look at all, but I have a look at the time I need to query the page.I can do it  across all paged tables in the UI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17481: [SPARK-20157]In the menu ‘Storage’in Web UI, click t...

Posted by guoxiaolongzte <gi...@git.apache.org>.

Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17481
  
    @ajbozarth
    I now need to constantly switch pageSize to change paging data. Sometimes I want to see all the data, but now show all the data, page area is lost. When I quit, I have to re-select the cache table url I just clicked. If cache table data very much, I found just click to view the cache table, need to spend more time.
    If all pageSize is displayed, the page area is not lost, and I can change pageSize again and click the Go button to view the paging data to better view the data.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17481: [SPARK-20157]In the menu ‘Storage’in Web UI, click t...

Posted by guoxiaolongzte <gi...@git.apache.org>.

Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17481
  
    @ajbozarth
    Sometimes watch I need to see all data, sometimes watch I need to see the paging data, if I go back, the cache data if too much, and I need to find a long time. But if the solution to this problem, I just don't take a long time to find my view of a certain cache table data.Spark a powerful UI, rather than relying on more of the browser's back button.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17481: [SPARK-20157]In the menu ‘Storage’in Web UI, click t...

Posted by ajbozarth <gi...@git.apache.org>.

Github user ajbozarth commented on the issue:

    https://github.com/apache/spark/pull/17481
  
    I'm not quite sure what you mean by cached, but the way paging is implemented every time you change the row count or page number it's a new page load/refresh, so the latest data will be shown (if it's still running). In short the paging is implemented with url params and a refresh so there is no caching


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17481: [SPARK-20157]In the menu ‘Storage’in Web UI, click t...

Posted by guoxiaolongzte <gi...@git.apache.org>.

Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17481
  
    @srowen 
    In jobs in web ui,Choose 'show' text box, fill in the data to show a number greater than or equal to the data to the total number of article. Click on the "Go" button, display interface display the total number of the data, but the page menu no disappear.
    In storage in web ui,
    Choose 'show' text box, fill in the data to show a number greater than or equal to the data to the total number of article. Click on the "Go" button, display interface display the total number of the data, but the page menu disappear.
    I still feel that I changed the more reasonable.
    
    Please refer to the attachment new.png of 'SPARK-20157'.
    issue url:https://issues.apache.org/jira/browse/SPARK-20157.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17481: [SPARK-20157]In the menu ‘Storage’in Web UI, click t...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17481
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org