You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by gubaojian <gi...@git.apache.org> on 2017/10/12 12:24:18 UTC
[GitHub] incubator-weex pull request #788: [Android]bug fix for list cell add event h...
GitHub user gubaojian opened a pull request:
https://github.com/apache/incubator-weex/pull/788
[Android]bug fix for list cell add event has none affect when cell not init
bug fix for list cell add event has none affect when cell not init
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gubaojian/incubator-weex release-0.16
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/788.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #788
----
commit e1eec866f243c498a88fb4e62517f2f086683ceb
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-12T12:23:34Z
bug fix for list cell add event has none affect when cell not init
----
---
[GitHub] incubator-weex pull request #788: [Android]bug fix for list cell add event h...
Posted by gubaojian <gi...@git.apache.org>.
GitHub user gubaojian reopened a pull request:
https://github.com/apache/incubator-weex/pull/788
[Android]bug fix for list cell add event has none affect when cell not init
1、bug fix for list cell add event has none affect when cell not init
2、sticky offset supported
3、keep position lost bugfix
4、sticky bugfix when none view
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gubaojian/incubator-weex release-0.16
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/788.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #788
----
commit e1eec866f243c498a88fb4e62517f2f086683ceb
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-12T12:23:34Z
bug fix for list cell add event has none affect when cell not init
commit 117fc2f5402f83b2af1a2301ac6b00bb615afc04
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-16T05:59:17Z
sticky offset supported, keep position lost when insert data fix
commit dc3718ec9fb85d9b6f4c9be3b30ec04a95b89433
Author: codefurture <gu...@163.com>
Date: 2017-10-17T01:56:17Z
Merge branch 'release-0.16' into release-0.16
commit fa6c474ea985c847435b5ef2baf3a7f445e347a4
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-17T03:15:53Z
resolve conflicts
----
---
[GitHub] incubator-weex issue #788: [Android]bug fix for list cell add event has none...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/788
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex pull request #788: [Android]bug fix for list cell add event h...
Posted by gubaojian <gi...@git.apache.org>.
GitHub user gubaojian reopened a pull request:
https://github.com/apache/incubator-weex/pull/788
[Android]bug fix for list cell add event has none affect when cell not init
1、bug fix for list cell add event has none affect when cell not init
2、sticky offset supported
3、keep position lost bugfix
4、sticky bugfix when none view
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gubaojian/incubator-weex release-0.16
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/788.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #788
----
commit e1eec866f243c498a88fb4e62517f2f086683ceb
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-12T12:23:34Z
bug fix for list cell add event has none affect when cell not init
commit 117fc2f5402f83b2af1a2301ac6b00bb615afc04
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-16T05:59:17Z
sticky offset supported, keep position lost when insert data fix
commit dc3718ec9fb85d9b6f4c9be3b30ec04a95b89433
Author: codefurture <gu...@163.com>
Date: 2017-10-17T01:56:17Z
Merge branch 'release-0.16' into release-0.16
commit fa6c474ea985c847435b5ef2baf3a7f445e347a4
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-17T03:15:53Z
resolve conflicts
commit 1f06724ab9404a967e9bd3f26f2a6a68be1244eb
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-17T06:58:05Z
Merge branch 'release-0.16' of https://github.com/apache/incubator-weex into release-0.16
commit 9824c4d2b90a1ee4d3549a12a54a4d2c06c05ab0
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-17T07:29:52Z
Merge branch 'release-0.16' of https://github.com/apache/incubator-weex into release-0.16
# Conflicts:
# android/sdk/src/main/java/com/taobao/weex/ui/component/list/WXCell.java
----
---
[GitHub] incubator-weex issue #788: [Android]bug fix for list cell add event has none...
Posted by gubaojian <gi...@git.apache.org>.
Github user gubaojian commented on the issue:
https://github.com/apache/incubator-weex/pull/788
good, code has merged
---
[GitHub] incubator-weex pull request #788: [Android]bug fix for list cell add event h...
Posted by gubaojian <gi...@git.apache.org>.
Github user gubaojian closed the pull request at:
https://github.com/apache/incubator-weex/pull/788
---
[GitHub] incubator-weex pull request #788: [Android]bug fix for list cell add event h...
Posted by gubaojian <gi...@git.apache.org>.
Github user gubaojian closed the pull request at:
https://github.com/apache/incubator-weex/pull/788
---
[GitHub] incubator-weex issue #788: [Android]bug fix for list cell add event has none...
Posted by gurisxie <gi...@git.apache.org>.
Github user gurisxie commented on the issue:
https://github.com/apache/incubator-weex/pull/788
has merged... but bot seems broken.
---
[GitHub] incubator-weex pull request #788: [Android]bug fix for list cell add event h...
Posted by gubaojian <gi...@git.apache.org>.
GitHub user gubaojian reopened a pull request:
https://github.com/apache/incubator-weex/pull/788
[Android]bug fix for list cell add event has none affect when cell not init
bug fix for list cell add event has none affect when cell not init
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gubaojian/incubator-weex release-0.16
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/788.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #788
----
commit e1eec866f243c498a88fb4e62517f2f086683ceb
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-12T12:23:34Z
bug fix for list cell add event has none affect when cell not init
commit 117fc2f5402f83b2af1a2301ac6b00bb615afc04
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-16T05:59:17Z
sticky offset supported, keep position lost when insert data fix
----
---
[GitHub] incubator-weex pull request #788: [Android]bug fix for list cell add event h...
Posted by misakuo <gi...@git.apache.org>.
Github user misakuo commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/788#discussion_r145012253
--- Diff: android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java ---
@@ -236,6 +245,9 @@ protected T initComponentHostView(@NonNull Context context) {
if (transforms != null) {
bounceRecyclerView.getInnerView().addItemDecoration(RecyclerTransform.parseTransforms(getOrientation(), transforms));
}
+ if(getDomObject().getAttrs().get(Constants.Name.KEEP_POSITION_LAYOUT_DELAY) != null){
--- End diff --
Need to judge whether it is null?
---
[GitHub] incubator-weex pull request #788: [Android]bug fix for list cell add event h...
Posted by gubaojian <gi...@git.apache.org>.
Github user gubaojian closed the pull request at:
https://github.com/apache/incubator-weex/pull/788
---
[GitHub] incubator-weex pull request #788: [Android]bug fix for list cell add event h...
Posted by gubaojian <gi...@git.apache.org>.
GitHub user gubaojian reopened a pull request:
https://github.com/apache/incubator-weex/pull/788
[Android]bug fix for list cell add event has none affect when cell not init
bug fix for list cell add event has none affect when cell not init
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gubaojian/incubator-weex release-0.16
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/788.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #788
----
commit e1eec866f243c498a88fb4e62517f2f086683ceb
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-12T12:23:34Z
bug fix for list cell add event has none affect when cell not init
----
---
[GitHub] incubator-weex pull request #788: [Android]bug fix for list cell add event h...
Posted by gubaojian <gi...@git.apache.org>.
Github user gubaojian closed the pull request at:
https://github.com/apache/incubator-weex/pull/788
---
[GitHub] incubator-weex pull request #788: [Android]bug fix for list cell add event h...
Posted by gubaojian <gi...@git.apache.org>.
Github user gubaojian closed the pull request at:
https://github.com/apache/incubator-weex/pull/788
---
[GitHub] incubator-weex pull request #788: [Android]bug fix for list cell add event h...
Posted by gubaojian <gi...@git.apache.org>.
Github user gubaojian closed the pull request at:
https://github.com/apache/incubator-weex/pull/788
---
[GitHub] incubator-weex pull request #788: [Android]bug fix for list cell add event h...
Posted by gubaojian <gi...@git.apache.org>.
GitHub user gubaojian reopened a pull request:
https://github.com/apache/incubator-weex/pull/788
[Android]bug fix for list cell add event has none affect when cell not init
1、bug fix for list cell add event has none affect when cell not init
2、sticky offset supported
3、keep position lost bugfix
4、sticky bugfix when none view
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gubaojian/incubator-weex release-0.16
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/788.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #788
----
commit e1eec866f243c498a88fb4e62517f2f086683ceb
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-12T12:23:34Z
bug fix for list cell add event has none affect when cell not init
commit 117fc2f5402f83b2af1a2301ac6b00bb615afc04
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-16T05:59:17Z
sticky offset supported, keep position lost when insert data fix
commit dc3718ec9fb85d9b6f4c9be3b30ec04a95b89433
Author: codefurture <gu...@163.com>
Date: 2017-10-17T01:56:17Z
Merge branch 'release-0.16' into release-0.16
commit fa6c474ea985c847435b5ef2baf3a7f445e347a4
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-17T03:15:53Z
resolve conflicts
commit 1f06724ab9404a967e9bd3f26f2a6a68be1244eb
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-17T06:58:05Z
Merge branch 'release-0.16' of https://github.com/apache/incubator-weex into release-0.16
----
---