You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Usman Ismail (JIRA)" <ji...@apache.org> on 2011/04/21 22:45:05 UTC
[jira] [Created] (THRIFT-1154) HttpClient does not specify the
connection close parameter
HttpClient does not specify the connection close parameter
----------------------------------------------------------
Key: THRIFT-1154
URL: https://issues.apache.org/jira/browse/THRIFT-1154
Project: Thrift
Issue Type: Bug
Components: Cocoa - Library
Affects Versions: 0.6
Reporter: Usman Ismail
Assignee: Usman Ismail
Fix For: 0.6.1
Attachments: ConnectionClose.patch
THttpClient.m builds a header fort he http request in the flush method but it does not set the Connection: Close header which means the client wait for EOF until the server closes the socket. This will slow all requests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1154) HttpClient does not specify the
connection close parameter
Posted by "Usman Ismail (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Usman Ismail updated THRIFT-1154:
---------------------------------
Attachment: ConnectionClose.patch
Adds the requeired headers
> HttpClient does not specify the connection close parameter
> ----------------------------------------------------------
>
> Key: THRIFT-1154
> URL: https://issues.apache.org/jira/browse/THRIFT-1154
> Project: Thrift
> Issue Type: Bug
> Components: Cocoa - Library
> Affects Versions: 0.6
> Reporter: Usman Ismail
> Assignee: Usman Ismail
> Labels: cocoa, httpclient, network
> Fix For: 0.6.1
>
> Attachments: ConnectionClose.patch
>
>
> THttpClient.m builds a header fort he http request in the flush method but it does not set the Connection: Close header which means the client wait for EOF until the server closes the socket. This will slow all requests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1154) HttpClient does not specify the
connection close parameter
Posted by "Usman Ismail (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025826#comment-13025826 ]
Usman Ismail commented on THRIFT-1154:
--------------------------------------
As per discussions in the mailing list this is not needed for Objective C because underlying networking stack takes care of it. We should however allow user specified headers to be added. I have created issue 1157 for it.
> HttpClient does not specify the connection close parameter
> ----------------------------------------------------------
>
> Key: THRIFT-1154
> URL: https://issues.apache.org/jira/browse/THRIFT-1154
> Project: Thrift
> Issue Type: Bug
> Components: Cocoa - Library
> Affects Versions: 0.6.1, 0.7
> Reporter: Usman Ismail
> Assignee: Usman Ismail
> Labels: cocoa, httpclient, network
> Fix For: 0.7
>
> Attachments: ConnectionClose.patch
>
>
> THttpClient.m builds a header fort he http request in the flush method but it does not set the Connection: Close header which means the client wait for EOF until the server closes the socket. This will slow all requests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1154) HttpClient does not specify the
connection close parameter
Posted by "Usman Ismail (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Usman Ismail resolved THRIFT-1154.
----------------------------------
Resolution: Not A Problem
> HttpClient does not specify the connection close parameter
> ----------------------------------------------------------
>
> Key: THRIFT-1154
> URL: https://issues.apache.org/jira/browse/THRIFT-1154
> Project: Thrift
> Issue Type: Bug
> Components: Cocoa - Library
> Affects Versions: 0.6.1, 0.7
> Reporter: Usman Ismail
> Assignee: Usman Ismail
> Labels: cocoa, httpclient, network
> Fix For: 0.7
>
> Attachments: ConnectionClose.patch
>
>
> THttpClient.m builds a header fort he http request in the flush method but it does not set the Connection: Close header which means the client wait for EOF until the server closes the socket. This will slow all requests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira