You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "breautek (via GitHub)" <gi...@apache.org> on 2026/06/17 19:22:42 UTC
[PR] chore: Update nyc [cordova-plugman]
breautek opened a new pull request, #198:
URL: https://github.com/apache/cordova-plugman/pull/198
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Updates `nyc` to the latest version which removes the `uuid` dependency, a source of audited vulnerabilities. v18 node engines is already satisfied with our engines that is committed into the master branch.
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
npm test
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore!: Replace nyc with c8 (with yargs v18 override) [cordova-plugman]
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #198:
URL: https://github.com/apache/cordova-plugman/pull/198#issuecomment-4742318770
Didn't change branch names but did update the title and commit message accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: Update nyc [cordova-plugman]
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu commented on PR #198:
URL: https://github.com/apache/cordova-plugman/pull/198#issuecomment-4737417461
We replaced `nyc` with `c8` in the other repos, so I think we could do the same here. It should be a straightforward change: replace the package, then update the `package.json` configuration and command usage by changing `nyc` to `c8`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: Update nyc [cordova-plugman]
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #198:
URL: https://github.com/apache/cordova-plugman/pull/198#issuecomment-4742258852
definitely not a fan of using the overrides but I can replace nyc with c8 with the yargs override for the sake of consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: Update nyc [cordova-plugman]
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #198:
URL: https://github.com/apache/cordova-plugman/pull/198#issuecomment-4742307115
```
norman@norman-workstation:/development/cordova/breautek/cordova-plugman$ npm ls yargs
plugman@4.0.0-dev /development/cordova/breautek/cordova-plugman
└─┬ c8@11.0.0 overridden
└── yargs@18.0.0 overridden
```
Had to also run `npm upgrade` which might have updated other sub-packages otherwise it produced:
```
npm ls yargs
plugman@4.0.0-dev /development/cordova/breautek/cordova-plugman
└─┬ c8@11.0.0 overridden
└── yargs@17.7.2 invalid: "^18.0.0" from node_modules/c8 overridden
npm error code ELSPROBLEMS
npm error invalid: yargs@17.7.2 /development/cordova/breautek/cordova-plugman/node_modules/c8/node_modules/yargs
npm error A complete log of this run can be found in: /home/norman/.npm/_logs/2026-06-18T13_13_03_088Z-debug-0.log
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore!: Replace nyc with c8 (with yargs v18 override) [cordova-plugman]
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu commented on code in PR #198:
URL: https://github.com/apache/cordova-plugman/pull/198#discussion_r3436297538
##########
package.json:
##########
Review Comment:
```suggestion
"c8": {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore!: Replace nyc with c8 (with yargs v18 override) [cordova-plugman]
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek merged PR #198:
URL: https://github.com/apache/cordova-plugman/pull/198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: Update nyc [cordova-plugman]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #198:
URL: https://github.com/apache/cordova-plugman/pull/198#issuecomment-4734387155
## [Codecov](https://app.codecov.io/gh/apache/cordova-plugman/pull/198?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 82.92%. Comparing base ([`5ba1d3a`](https://app.codecov.io/gh/apache/cordova-plugman/commit/5ba1d3ad050b2955034ef8f0462e7b000ce955b6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9e80e61`](https://app.codecov.io/gh/apache/cordova-plugman/commit/9e80e619c708f81f9c717720f8b25d87e5efd35f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #198 +/- ##
===========================================
+ Coverage 59.15% 82.92% +23.77%
===========================================
Files 5 5
Lines 71 82 +11
===========================================
+ Hits 42 68 +26
+ Misses 29 14 -15
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/cordova-plugman/pull/198?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore!: Replace nyc with c8 (with yargs v18 override) [cordova-plugman]
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on code in PR #198:
URL: https://github.com/apache/cordova-plugman/pull/198#discussion_r3436401798
##########
package.json:
##########
Review Comment:
Assuming c8 uses the same options as nyc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: Update nyc [cordova-plugman]
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on PR #198:
URL: https://github.com/apache/cordova-plugman/pull/198#issuecomment-4738127356
yargs 17 (which c8 depends on) is not compatible with Node 26: https://github.com/yargs/yargs/issues/2509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore!: Replace nyc with c8 (with yargs v18 override) [cordova-plugman]
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu commented on code in PR #198:
URL: https://github.com/apache/cordova-plugman/pull/198#discussion_r3436309954
##########
package.json:
##########
Review Comment:
This will also need to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org