You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/11/29 18:45:27 UTC
[GitHub] [nifi] turcsanyip opened a new pull request #5557: NIFI-9421: Running NiFi Stateless with local NARs only
turcsanyip opened a new pull request #5557:
URL: https://github.com/apache/nifi/pull/5557
https://issues.apache.org/jira/browse/NIFI-9421
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] gresockj commented on pull request #5557: NIFI-9421: Running NiFi Stateless with local NARs only
Posted by GitBox <gi...@apache.org>.
gresockj commented on pull request #5557:
URL: https://github.com/apache/nifi/pull/5557#issuecomment-989189674
Thanks for the update, @turcsanyip -- will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a change in pull request #5557: NIFI-9421: Running NiFi Stateless with local NARs only
Posted by GitBox <gi...@apache.org>.
turcsanyip commented on a change in pull request #5557:
URL: https://github.com/apache/nifi/pull/5557#discussion_r765230386
##########
File path: nifi-stateless/nifi-stateless-assembly/README.md
##########
@@ -221,8 +221,11 @@ The following properties may be used to indicate where extensions are to be loca
When Stateless NiFi is started, it parses the provided dataflow and determines which bundles/extensions are necessary
to run the dataflow. If an extension is not available, or the version referenced by the flow is not available, Stateless
-may attempt to download the extensions automatically. To do this, one or more Extension Clients must be configured.
-Each client is configured using several properties, which are all tied together using a 'key'. For example, if we have
+may attempt to download the extensions automatically. To do this, one or more Extension Clients need to be configured. If no
+Extension Clients configured, only those extensions can be used that are already available (e.g. manually downloaded and copied offline)
Review comment:
@gresockj Thanks for the review! I fixed the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] gresockj commented on a change in pull request #5557: NIFI-9421: Running NiFi Stateless with local NARs only
Posted by GitBox <gi...@apache.org>.
gresockj commented on a change in pull request #5557:
URL: https://github.com/apache/nifi/pull/5557#discussion_r765035714
##########
File path: nifi-stateless/nifi-stateless-assembly/README.md
##########
@@ -221,8 +221,11 @@ The following properties may be used to indicate where extensions are to be loca
When Stateless NiFi is started, it parses the provided dataflow and determines which bundles/extensions are necessary
to run the dataflow. If an extension is not available, or the version referenced by the flow is not available, Stateless
-may attempt to download the extensions automatically. To do this, one or more Extension Clients must be configured.
-Each client is configured using several properties, which are all tied together using a 'key'. For example, if we have
+may attempt to download the extensions automatically. To do this, one or more Extension Clients need to be configured. If no
+Extension Clients configured, only those extensions can be used that are already available (e.g. manually downloaded and copied offline)
Review comment:
"Extension Clients are configured" *
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #5557: NIFI-9421: Running NiFi Stateless with local NARs only
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #5557:
URL: https://github.com/apache/nifi/pull/5557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org