You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "liunaijie (via GitHub)" <gi...@apache.org> on 2023/07/12 02:55:51 UTC
[GitHub] [seatunnel] liunaijie opened a new pull request, #5065: [Feature] update action config to support run CI on fork repo
liunaijie opened a new pull request, #5065:
URL: https://github.com/apache/seatunnel/pull/5065
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
This update will let the CI run on fork repo.
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] liugddx closed pull request #5065: [Feature] update action config to support run CI on fork repo
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx closed pull request #5065: [Feature] update action config to support run CI on fork repo
URL: https://github.com/apache/seatunnel/pull/5065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] EricJoy2048 merged pull request #5065: [Feature] update action config to support run CI on fork repo
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 merged PR #5065:
URL: https://github.com/apache/seatunnel/pull/5065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] liugddx commented on a diff in pull request #5065: [Feature] update action config to support run CI on fork repo
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on code in PR #5065:
URL: https://github.com/apache/seatunnel/pull/5065#discussion_r1260530012
##########
.github/workflows/backend.yml:
##########
@@ -18,9 +18,9 @@
name: Backend
on:
push:
+ pull_request:
Review Comment:
> Do we need to remove below setting?
>
> ```
> branches:
> - dev
> ```
>
> This will cause only submit PR to dev will trigger the workflow?
@EricJoy2048 @hailin0 @Hisoka-X @ic4y PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] ruanwenjun commented on a diff in pull request #5065: [Feature] update action config to support run CI on fork repo
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #5065:
URL: https://github.com/apache/seatunnel/pull/5065#discussion_r1260523259
##########
.github/workflows/backend.yml:
##########
@@ -18,9 +18,9 @@
name: Backend
on:
push:
+ pull_request:
Review Comment:
Do we need to remove below setting?
```
branches:
- dev
```
This will cause only submit PR to dev will trigger the workflow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] liugddx commented on pull request #5065: [Feature] update action config to support run CI on fork repo
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #5065:
URL: https://github.com/apache/seatunnel/pull/5065#issuecomment-1631779540
> @liugddx PTAL, i changed some code base on your pr.
Good job !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] liugddx commented on a diff in pull request #5065: [Feature] update action config to support run CI on fork repo
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on code in PR #5065:
URL: https://github.com/apache/seatunnel/pull/5065#discussion_r1260530263
##########
.github/workflows/backend.yml:
##########
@@ -18,9 +18,9 @@
name: Backend
on:
push:
+ pull_request:
Review Comment:
> > Do we need to remove below setting?
> > ```
> > branches:
> > - dev
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > This will cause only submit PR to dev will trigger the workflow?
>
> @EricJoy2048 @hailin0 @Hisoka-X @ic4y PTAL
@TyrantLucifer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] liugddx commented on a diff in pull request #5065: [Feature] update action config to support run CI on fork repo
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on code in PR #5065:
URL: https://github.com/apache/seatunnel/pull/5065#discussion_r1260534203
##########
.github/workflows/backend.yml:
##########
@@ -18,9 +18,9 @@
name: Backend
on:
push:
+ pull_request:
Review Comment:
> Do we need to remove below setting?
>
> ```
> branches:
> - dev
> ```
>
> This will cause only submit PR to dev will trigger the workflow?
I think there is no problem with the dev branch, we are mainly developing in the dev branch now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] liunaijie commented on a diff in pull request #5065: [Feature] update action config to support run CI on fork repo
Posted by "liunaijie (via GitHub)" <gi...@apache.org>.
liunaijie commented on code in PR #5065:
URL: https://github.com/apache/seatunnel/pull/5065#discussion_r1260614300
##########
.github/workflows/backend.yml:
##########
@@ -18,9 +18,9 @@
name: Backend
on:
push:
+ pull_request:
Review Comment:
only trigger on dev rule is added on this pr: https://github.com/apache/seatunnel/pull/4522/files.
For this pr, my purpose is enable the CI on fork repo. Then it can run CI on fork repo first to check, fix error to reduce everyone's time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] ruanwenjun commented on a diff in pull request #5065: [Feature] update action config to support run CI on fork repo
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #5065:
URL: https://github.com/apache/seatunnel/pull/5065#discussion_r1260599986
##########
.github/workflows/backend.yml:
##########
@@ -18,9 +18,9 @@
name: Backend
on:
push:
+ pull_request:
Review Comment:
If we cp to release-branch, the ci will not trigger, it would be better to keep the origin rule.
Why we add the new rule "only trigger on dev"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] liunaijie commented on pull request #5065: [Feature] update action config to support run CI on fork repo
Posted by "liunaijie (via GitHub)" <gi...@apache.org>.
liunaijie commented on PR #5065:
URL: https://github.com/apache/seatunnel/pull/5065#issuecomment-1631775800
@liugddx PTAL, i changed some code base on your pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org