You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/21 09:51:19 UTC

[GitHub] [pulsar] eolivelli commented on a diff in pull request #16472: [cleanup][functions] Remove unused code

eolivelli commented on code in PR #16472:
URL: https://github.com/apache/pulsar/pull/16472#discussion_r926482611


##########
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java:
##########
@@ -855,13 +854,8 @@ protected List<String> getExecutorCommand() {
     }
 
     private List<String> getDownloadCommand(Function.FunctionDetails functionDetails, String userCodeFilePath) {
-        if (Arrays.stream(PackageType.values()).anyMatch(type ->

Review Comment:
   I think that "functions download" should work as expected, that is to download from DLog or from PackageManagement
   
   do you have any pointers about the problem ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org