You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/18 09:04:41 UTC
[jira] [Commented] (CB-12667) Cordova-plugin-device-orientation
plugin can not find orientation sensor on Samsung devices
[ https://issues.apache.org/jira/browse/CB-12667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972355#comment-15972355 ]
ASF GitHub Bot commented on CB-12667:
-------------------------------------
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
CB-12667 android: Added logic for searching sensors from Samsung vendor
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
This PR adds opportunity for searching orientation sensors which have specific orientation type (it's relevant for Samsung devices).
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-plugin-device-orientation samsung-orientation-type
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-device-orientation/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit f055c16400b823923265d993c1ec35d9cfe43bf0
Author: Nikita Matrosov <v-...@microsoft.com>
Date: 2017-04-18T08:58:25Z
CB-12667 android: Added logic for searching sensors from Samsung vendor
----
> Cordova-plugin-device-orientation plugin can not find orientation sensor on Samsung devices
> --------------------------------------------------------------------------------------------
>
> Key: CB-12667
> URL: https://issues.apache.org/jira/browse/CB-12667
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Device Orientation
> Affects Versions: Master
> Environment: cordova- 6.5.1-dev
> cordova-plugin-device-orientation - 1.0.6
> Reporter: Nikita Matrosov
> Assignee: Nikita Matrosov
>
> Device model: Samsung SM-G361H
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org