You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by mm...@apache.org on 2011/07/27 02:18:25 UTC
svn commit: r1151298 - in /spamassassin/trunk: lib/Mail/SpamAssassin.pm
lib/Mail/SpamAssassin/PerMsgStatus.pm lib/Mail/SpamAssassin/Util.pm
xt/60_perlcritic.t
Author: mmartinec
Date: Wed Jul 27 00:18:24 2011
New Revision: 1151298
URL: http://svn.apache.org/viewvc?rev=1151298&view=rev
Log:
avoid a Test::Perl::Critic warning Subroutines::ProhibitSubroutinePrototypes as reported by xt/60_perlcritic.t
Modified:
spamassassin/trunk/lib/Mail/SpamAssassin.pm
spamassassin/trunk/lib/Mail/SpamAssassin/PerMsgStatus.pm
spamassassin/trunk/lib/Mail/SpamAssassin/Util.pm
spamassassin/trunk/xt/60_perlcritic.t
Modified: spamassassin/trunk/lib/Mail/SpamAssassin.pm
URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin.pm?rev=1151298&r1=1151297&r2=1151298&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin.pm Wed Jul 27 00:18:24 2011
@@ -1967,7 +1967,7 @@ sub create_default_prefs {
###########################################################################
-sub expand_name ($) {
+sub expand_name {
my ($self, $name) = @_;
my $home = $self->{user_dir} || $ENV{HOME} || '';
Modified: spamassassin/trunk/lib/Mail/SpamAssassin/PerMsgStatus.pm
URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/PerMsgStatus.pm?rev=1151298&r1=1151297&r2=1151298&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/PerMsgStatus.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/PerMsgStatus.pm Wed Jul 27 00:18:24 2011
@@ -709,7 +709,7 @@ sub _fixup_report_line_endings {
}
}
-sub _get_added_headers($) {
+sub _get_added_headers {
my ($self, $which) = @_;
my $str = '';
# use string appends to put this back together -- I finally benchmarked it.
Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Util.pm
URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Util.pm?rev=1151298&r1=1151297&r2=1151298&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/Util.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/Util.pm Wed Jul 27 00:18:24 2011
@@ -319,7 +319,7 @@ sub taint_var {
# append optional mesage (dual-valued errno or a string or a number),
# returning the resulting string
#
-sub exit_status_str($;$) {
+sub exit_status_str {
my($stat,$errno) = @_;
my $str;
if (!defined($stat)) {
@@ -349,7 +349,7 @@ sub exit_status_str($;$) {
# check errno to be 0 and a process exit status to be in the list of success
# status codes, returning true if both are ok, and false otherwise
#
-sub proc_status_ok($;$@) {
+sub proc_status_ok {
my($exit_status,$errno,@success) = @_;
my $ok = 0;
if ((!defined $errno || $errno == 0) && WIFEXITED($exit_status)) {
Modified: spamassassin/trunk/xt/60_perlcritic.t
URL: http://svn.apache.org/viewvc/spamassassin/trunk/xt/60_perlcritic.t?rev=1151298&r1=1151297&r2=1151298&view=diff
==============================================================================
--- spamassassin/trunk/xt/60_perlcritic.t (original)
+++ spamassassin/trunk/xt/60_perlcritic.t Wed Jul 27 00:18:24 2011
@@ -29,7 +29,7 @@ print RC q{
severity = 5
verbose = 10
- exclude = ValuesAndExpressions::ProhibitLeadingZeros InputOutput::ProhibitBarewordFileHandles InputOutput::ProhibitTwoArgOpen Subroutines::ProhibitSubroutinePrototypes BuiltinFunctions::ProhibitStringyEval InputOutput::ProhibitInteractiveTest
+ exclude = ValuesAndExpressions::ProhibitLeadingZeros InputOutput::ProhibitBarewordFileHandles InputOutput::ProhibitTwoArgOpen BuiltinFunctions::ProhibitStringyEval InputOutput::ProhibitInteractiveTest
[TestingAndDebugging::ProhibitNoStrict]
allow = refs