You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "wsjz (via GitHub)" <gi...@apache.org> on 2023/11/15 02:02:49 UTC

[PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

wsjz opened a new pull request, #27007:
URL: https://github.com/apache/doris/pull/27007

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1816511691

   run feut beut clickbench


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1817889275

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1815659403

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1813908972

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #27007:
URL: https://github.com/apache/doris/pull/27007#discussion_r1393680076


##########
fe/be-java-extensions/max-compute-scanner/src/main/java/org/apache/doris/maxcompute/MaxComputeJniScanner.java:
##########
@@ -167,10 +172,21 @@ public void open() throws IOException {
             List<Column> maxComputeColumns = new ArrayList<>(readColumns);
             maxComputeColumns.removeIf(e -> partitionColumns.contains(e.getName()));
             curReader = session.openArrowRecordReader(start, totalRows, maxComputeColumns, arrowAllocator);
+        } catch (TunnelException e) {
+            if (retryCount > 0 && e.getErrorMsg().contains("TableModified")) {
+                retryCount--;
+                // try to refresh table scan and re-open odps
+                refreshTableScan();
+                open();
+            } else {
+                retryCount = 2;

Review Comment:
   Why need to reset `retryCount`?
   I thought the MaxComputeJniScanner will be new for each query?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1814004032

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit ff22abb2a9091bb7dc962d685eb4cb891d981945, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4941	4666	4715	4666
   q2	358	158	168	158
   q3	2029	1968	1895	1895
   q4	1387	1224	1217	1217
   q5	3955	3960	4092	3960
   q6	244	132	135	132
   q7	1413	878	889	878
   q8	2772	2817	2776	2776
   q9	9590	9600	9564	9564
   q10	3509	3572	3532	3532
   q11	370	237	244	237
   q12	431	294	297	294
   q13	4578	3820	3787	3787
   q14	332	280	295	280
   q15	577	539	518	518
   q16	673	587	576	576
   q17	1142	980	932	932
   q18	7839	7386	7393	7386
   q19	1682	1690	1690	1690
   q20	582	352	302	302
   q21	4355	3983	3984	3983
   q22	470	383	376	376
   Total cold run time: 53229 ms
   Total hot run time: 49139 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4566	4571	4575	4571
   q2	339	227	270	227
   q3	4046	4008	4012	4008
   q4	2718	2704	2688	2688
   q5	9637	9583	9706	9583
   q6	244	122	125	122
   q7	3013	2472	2510	2472
   q8	4431	4431	4432	4431
   q9	12904	12910	12886	12886
   q10	4113	4191	4218	4191
   q11	796	670	645	645
   q12	969	804	815	804
   q13	4291	3570	3581	3570
   q14	364	348	334	334
   q15	570	535	531	531
   q16	736	665	675	665
   q17	3946	3857	3906	3857
   q18	9608	8963	9054	8963
   q19	1861	1806	1786	1786
   q20	2385	2049	2037	2037
   q21	8854	8500	8580	8500
   q22	919	793	773	773
   Total cold run time: 81310 ms
   Total hot run time: 77644 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1817891322

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1815870582

   run external


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1815740084

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 45.91 seconds
    stream load tsv:          584 seconds loaded 74807831229 Bytes, about 122 MB/s
    stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          33 seconds loaded 861443392 Bytes, about 24 MB/s
    insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
    storage size: 17099366214 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1813859838

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #27007:
URL: https://github.com/apache/doris/pull/27007


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1815870392

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1817933930

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 45.25 seconds
    stream load tsv:          564 seconds loaded 74807831229 Bytes, about 126 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          33 seconds loaded 861443392 Bytes, about 24 MB/s
    insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
    storage size: 17099487474 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1813891231

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.55 seconds
    stream load tsv:          563 seconds loaded 74807831229 Bytes, about 126 MB/s
    stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          27.9 seconds inserted 10000000 Rows, about 358K ops/s
    storage size: 17097145284 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1813947474

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.75 seconds
    stream load tsv:          568 seconds loaded 74807831229 Bytes, about 125 MB/s
    stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          27.9 seconds inserted 10000000 Rows, about 358K ops/s
    storage size: 17099285646 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1817931012

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit fad592abe5e1c9cff8a39f3219e6a3a66f0b7d8c, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4849	4625	4661	4625
   q2	357	176	158	158
   q3	2021	1915	1875	1875
   q4	1385	1262	1228	1228
   q5	3898	3912	3990	3912
   q6	252	127	131	127
   q7	1396	896	886	886
   q8	2746	2745	2737	2737
   q9	9725	9529	9480	9480
   q10	10228	3478	3489	3478
   q11	377	252	244	244
   q12	433	289	292	289
   q13	4527	3820	3798	3798
   q14	312	295	295	295
   q15	580	536	523	523
   q16	667	589	578	578
   q17	1125	954	912	912
   q18	7835	7466	7474	7466
   q19	1648	1665	1633	1633
   q20	569	311	304	304
   q21	4434	3930	4045	3930
   q22	474	370	381	370
   Total cold run time: 59838 ms
   Total hot run time: 48848 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4566	4561	4546	4546
   q2	336	253	240	240
   q3	4020	4000	4003	4000
   q4	2720	2715	2709	2709
   q5	9670	9671	9635	9635
   q6	244	120	117	117
   q7	3033	2465	2490	2465
   q8	4472	4475	4457	4457
   q9	12930	12838	12864	12838
   q10	4044	4164	4161	4161
   q11	757	628	649	628
   q12	984	829	815	815
   q13	4271	3575	3573	3573
   q14	387	358	337	337
   q15	567	525	509	509
   q16	730	683	672	672
   q17	3796	3861	3841	3841
   q18	9645	9196	9241	9196
   q19	1849	1762	1770	1762
   q20	2410	2037	2048	2037
   q21	8842	8661	8739	8661
   q22	877	817	769	769
   Total cold run time: 81150 ms
   Total hot run time: 77968 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1816508920

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1816756593

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit 20cc7329a3fb39983f0cf1667a91f1d9a79f7824, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4910	4696	4678	4678
   q2	357	157	150	150
   q3	2021	1937	1900	1900
   q4	1411	1261	1225	1225
   q5	3998	3899	4023	3899
   q6	254	130	132	130
   q7	1446	885	903	885
   q8	2777	2786	2774	2774
   q9	9680	9492	9532	9492
   q10	3455	3502	3525	3502
   q11	394	242	243	242
   q12	435	288	295	288
   q13	4556	3785	3823	3785
   q14	317	299	294	294
   q15	590	538	526	526
   q16	674	583	588	583
   q17	1138	959	940	940
   q18	7840	7421	7533	7421
   q19	1683	1665	1674	1665
   q20	575	319	316	316
   q21	4413	3982	4073	3982
   q22	484	382	395	382
   Total cold run time: 53408 ms
   Total hot run time: 49059 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4593	4575	4569	4569
   q2	335	225	262	225
   q3	4032	3993	3997	3993
   q4	2713	2716	2710	2710
   q5	9663	9595	9633	9595
   q6	248	126	125	125
   q7	3033	2475	2478	2475
   q8	4437	4417	4414	4414
   q9	13007	12863	12888	12863
   q10	4049	4127	4153	4127
   q11	785	645	704	645
   q12	969	818	807	807
   q13	4334	3570	3609	3570
   q14	400	342	356	342
   q15	571	530	522	522
   q16	739	667	662	662
   q17	3940	3846	3834	3834
   q18	9666	9187	9157	9157
   q19	1788	1758	1772	1758
   q20	2412	2077	2062	2062
   q21	8803	8714	8681	8681
   q22	906	784	832	784
   Total cold run time: 81423 ms
   Total hot run time: 77920 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1816765780

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 45.02 seconds
    stream load tsv:          564 seconds loaded 74807831229 Bytes, about 126 MB/s
    stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          34 seconds loaded 861443392 Bytes, about 24 MB/s
    insert into select:          28.8 seconds inserted 10000000 Rows, about 347K ops/s
    storage size: 17099339651 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1813972900

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit c1a781218846bf40a2fa1ab0aaa665d33d6f0307, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	8138	4771	4721	4721
   q2	534	160	176	160
   q3	3188	1937	1911	1911
   q4	6545	1159	1267	1159
   q5	6862	4062	3997	3997
   q6	244	130	128	128
   q7	1416	889	897	889
   q8	9721	2824	2778	2778
   q9	10058	11047	9430	9430
   q10	8998	3549	3554	3549
   q11	427	249	249	249
   q12	457	294	296	294
   q13	21797	3806	3856	3806
   q14	324	280	286	280
   q15	581	529	521	521
   q16	659	591	594	591
   q17	1169	978	934	934
   q18	7819	7441	7460	7441
   q19	1728	1670	1677	1670
   q20	566	294	297	294
   q21	4383	3957	3961	3957
   q22	472	370	372	370
   Total cold run time: 96086 ms
   Total hot run time: 49129 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4594	4598	4579	4579
   q2	347	237	285	237
   q3	4017	4009	4020	4009
   q4	2742	2698	2708	2698
   q5	9744	9553	9669	9553
   q6	242	122	124	122
   q7	3051	2495	2517	2495
   q8	4409	4434	4451	4434
   q9	12955	12909	12942	12909
   q10	4091	4215	4214	4214
   q11	797	735	707	707
   q12	972	812	830	812
   q13	4314	3563	3564	3563
   q14	376	347	346	346
   q15	578	526	533	526
   q16	736	708	678	678
   q17	3862	3800	3898	3800
   q18	9678	9133	9018	9018
   q19	1841	1807	1773	1773
   q20	2396	2062	2063	2062
   q21	8974	8589	8718	8589
   q22	856	768	760	760
   Total cold run time: 81572 ms
   Total hot run time: 77884 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1816658116

   run beut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1816508981

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1817899589

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #27007:
URL: https://github.com/apache/doris/pull/27007#issuecomment-1816657997

   run clickbench


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](multi-catalog)add the max compute fe ut and fix download expired [doris]

Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on code in PR #27007:
URL: https://github.com/apache/doris/pull/27007#discussion_r1395070458


##########
fe/be-java-extensions/max-compute-scanner/src/main/java/org/apache/doris/maxcompute/MaxComputeJniScanner.java:
##########
@@ -167,10 +172,21 @@ public void open() throws IOException {
             List<Column> maxComputeColumns = new ArrayList<>(readColumns);
             maxComputeColumns.removeIf(e -> partitionColumns.contains(e.getName()));
             curReader = session.openArrowRecordReader(start, totalRows, maxComputeColumns, arrowAllocator);
+        } catch (TunnelException e) {
+            if (retryCount > 0 && e.getErrorMsg().contains("TableModified")) {
+                retryCount--;
+                // try to refresh table scan and re-open odps
+                refreshTableScan();
+                open();
+            } else {
+                retryCount = 2;

Review Comment:
   avoid to call open twice



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org