You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/09 16:52:59 UTC
[kudu-CR] Fix one more flakiness in tablet replacement-itest
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4345
to review the following change.
Change subject: Fix one more flakiness in tablet_replacement-itest
......................................................................
Fix one more flakiness in tablet_replacement-itest
The same as 30a8337f05a8b92faff9400298aae640b6ebbecb, there was a case
where we were electing a leader and assuming it could immediately
perform a config change, even though its original NO_OP may not have
been committed yet.
Change-Id: I1924e3fd001887d166866252f268354827a9da41
---
M src/kudu/integration-tests/tablet_replacement-itest.cc
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/4345/1
--
To view, visit http://gerrit.cloudera.org:8080/4345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1924e3fd001887d166866252f268354827a9da41
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Fix one more flakiness in tablet replacement-itest
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Fix one more flakiness in tablet_replacement-itest
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1924e3fd001887d166866252f268354827a9da41
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix one more flakiness in tablet replacement-itest
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: Fix one more flakiness in tablet_replacement-itest
......................................................................
Fix one more flakiness in tablet_replacement-itest
The same as 30a8337f05a8b92faff9400298aae640b6ebbecb, there was a case
where we were electing a leader and assuming it could immediately
perform a config change, even though its original NO_OP may not have
been committed yet.
Change-Id: I1924e3fd001887d166866252f268354827a9da41
Reviewed-on: http://gerrit.cloudera.org:8080/4345
Tested-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/integration-tests/tablet_replacement-itest.cc
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Todd Lipcon: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1924e3fd001887d166866252f268354827a9da41
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Fix one more flakiness in tablet replacement-itest
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Fix one more flakiness in tablet_replacement-itest
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3305/
--
To view, visit http://gerrit.cloudera.org:8080/4345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1924e3fd001887d166866252f268354827a9da41
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix one more flakiness in tablet replacement-itest
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Fix one more flakiness in tablet_replacement-itest
......................................................................
Patch Set 1: Verified+1
Test failure was an unrelated flake in debug-util-test. Put up a patch for that following this one.
--
To view, visit http://gerrit.cloudera.org:8080/4345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1924e3fd001887d166866252f268354827a9da41
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No