[GitHub] [gobblin] Will-Lo commented on a diff in pull request #3502: [GOBBLIN-1641] Add meter for sla exceeded flows

[GitBox <gi...@apache.org>]

Will-Lo commented on code in PR #3502:
URL: https://github.com/apache/gobblin/pull/3502#discussion_r866274218


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -357,6 +357,8 @@ public synchronized void setActive(boolean active) {
 
         ContextAwareMeter allSuccessfulMeter = null;
         ContextAwareMeter allFailedMeter = null;
+        // TODO: create a map of RatioGauges for success/failed per executor, will require preprocessing of available executors
+        Map<String, ContextAwareMeter> startSlaExceededMeters = Maps.newConcurrentMap();

Review Comment:
   a. I was thinking of a more robust metrics accounting that could do RatioGauges, which is an abstract class https://www.javadoc.io/static/io.dropwizard.metrics/metrics-core/3.1.2/com/codahale/metrics/RatioGauge.html that takes in 2 meters. I was thinking that if we were to also report ratios, then they need a reference to both the corresponding meters as well? Haven't thought it out all the way.
   
   b. I was thinking with ratios we'd have percentage of successful/failed jobs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org