You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "BradWalker (via GitHub)" <gi...@apache.org> on 2023/05/26 13:58:29 UTC
[GitHub] [netbeans] BradWalker opened a new pull request, #5992: Cleanup redundant cast warnings..
BradWalker opened a new pull request, #5992:
URL: https://github.com/apache/netbeans/pull/5992
As a result of much of the warning cleanup work I've done over the past couple of years, the redundant cast warnings start happening more fequently.
```
[repeat] /home/bwalker/src/netbeans/platform/core.multitabs/src/org/netbeans/core/multitabs/impl/ButtonPopupSwitcher.java:344: warning: [cast] redundant cast to Item
[repeat] final Item item = ( Item ) pTable.getSelectedItem();
[repeat] ^
```
This works reduces those warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #5992: Cleanup redundant cast warnings..
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker commented on PR #5992:
URL: https://github.com/apache/netbeans/pull/5992#issuecomment-1564595797
>
Thanks for the feedback/pointer. I wasn't aware of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5992: Cleanup redundant cast warnings..
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5992:
URL: https://github.com/apache/netbeans/pull/5992#issuecomment-1564568543
hi @BradWalker. PRs like this one here do always require the https://github.com/apache/netbeans/labels/ci%3Aall-tests label. Since they change code across the repository.
more info on how CI works is on the [wiki](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5992: Cleanup redundant cast warnings..
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5992:
URL: https://github.com/apache/netbeans/pull/5992#issuecomment-1564600557
no worries brad. Also, restarting existing workflows won't take changes in labels into account unfortunately. We have a secret button which forces a new workflow though which I will now use :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker merged pull request #5992: Cleanup redundant cast warnings..
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker merged PR #5992:
URL: https://github.com/apache/netbeans/pull/5992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #5992: Cleanup redundant cast warnings..
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker commented on PR #5992:
URL: https://github.com/apache/netbeans/pull/5992#issuecomment-1566285580
> Looks good to me. You might consider removing the `new Integer()` calls in `TableElementImpl.java` and rely on autoboxing.
Hey @matthiasblaesing , I'm getting ready to clean up the few remaining calls to `new Integer().`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists