You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "pnowojski (via GitHub)" <gi...@apache.org> on 2025/12/05 13:27:26 UTC
[PR] [FLINK-38764] Upgrade lz4 to 1.8.1 due to security vulnerability [flink]
pnowojski opened a new pull request, #27326:
URL: https://github.com/apache/flink/pull/27326
## What is the purpose of the change
Upgrade lz4 to 1.8.1 due to security vulnerability
## Verifying this change
Change should be covered by the existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**yes** / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38764] Upgrade lz4 to 1.8.1 due to security vulnerability [flink]
Posted by "Savonitar (via GitHub)" <gi...@apache.org>.
Savonitar commented on PR #27326:
URL: https://github.com/apache/flink/pull/27326#issuecomment-3928453704
Hi.
There is another [PR](https://github.com/apache/flink/pull/27535) that tackles this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38764] Upgrade lz4 to 1.8.1 due to security vulnerability [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #27326:
URL: https://github.com/apache/flink/pull/27326#issuecomment-3616947108
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42cb20795847bfb2042eb8121c77d52f6f8c9299",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "42cb20795847bfb2042eb8121c77d52f6f8c9299",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 42cb20795847bfb2042eb8121c77d52f6f8c9299 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38764] Upgrade lz4 to 1.8.1 due to security vulnerability [flink]
Posted by "Savonitar (via GitHub)" <gi...@apache.org>.
Savonitar commented on code in PR #27326:
URL: https://github.com/apache/flink/pull/27326#discussion_r2604616647
##########
flink-dist/src/main/resources/META-INF/NOTICE:
##########
@@ -6,6 +6,7 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
+- at.yawk.lz4:lz4-java:1.8.1
Review Comment:
Btw, upstream Apache Kafka (in trunk) has already migrated to the `at.yawk` fork and is [currently using version 1.10.1](https://github.com/apache/kafka/blob/trunk/gradle/dependencies.gradle#L113)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38764] Upgrade lz4 to 1.8.1 due to security vulnerability [flink]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #27326:
URL: https://github.com/apache/flink/pull/27326#discussion_r2694977547
##########
flink-dist/src/main/resources/META-INF/NOTICE:
##########
@@ -6,6 +6,7 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
+- at.yawk.lz4:lz4-java:1.8.1
Review Comment:
And another cve fix in 1.10.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38764] Upgrade lz4 to 1.8.1 due to security vulnerability [flink]
Posted by "pnowojski (via GitHub)" <gi...@apache.org>.
pnowojski commented on PR #27326:
URL: https://github.com/apache/flink/pull/27326#issuecomment-3617790254
lz4 1.8.0 is still being pulled from our Kafka connector, via Kafka client 🤔
```
[INFO] +- org.apache.flink:flink-connector-kafka:jar:3.0.0-1.17:compile
[INFO] | +- org.apache.flink:flink-connector-base:jar:1.17.0:compile
[INFO] | \- org.apache.kafka:kafka-clients:jar:3.2.3:compile
[INFO] | +- com.github.luben:zstd-jni:jar:1.5.2-1:runtime
[INFO] | \- org.lz4:lz4-java:jar:1.8.0:runtime
```
Kafka connector is pulled in from examples and in some tests, so on the one hand I think we should be fine just ignoring it until kafka connector upgrades it's own dependency 🤔 But on the other hand I'm worried about dependency convergence if someone tries to use Flink with lz4 1.8.1 with Kafka Connector with lz4 1.8.0.
I'm not 100% sure how to procede here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38764] Upgrade lz4 to 1.8.1 due to security vulnerability [flink]
Posted by "sajjadrizvi (via GitHub)" <gi...@apache.org>.
sajjadrizvi commented on PR #27326:
URL: https://github.com/apache/flink/pull/27326#issuecomment-3755363526
Hi,
Thank you for fixing it. Any plans to merge this soon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38764] Upgrade lz4 to 1.8.1 due to security vulnerability [flink]
Posted by "avi-sanwal (via GitHub)" <gi...@apache.org>.
avi-sanwal commented on PR #27326:
URL: https://github.com/apache/flink/pull/27326#issuecomment-3800354687
@pnowojski what are your thoughts about moving to 1.10.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38764] Upgrade lz4 to 1.8.1 due to security vulnerability [flink]
Posted by "pnowojski (via GitHub)" <gi...@apache.org>.
pnowojski commented on PR #27326:
URL: https://github.com/apache/flink/pull/27326#issuecomment-3925768778
@Savonitar is taking over this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38764] Upgrade lz4 to 1.8.1 due to security vulnerability [flink]
Posted by "Savonitar (via GitHub)" <gi...@apache.org>.
Savonitar commented on code in PR #27326:
URL: https://github.com/apache/flink/pull/27326#discussion_r2604616647
##########
flink-dist/src/main/resources/META-INF/NOTICE:
##########
@@ -6,6 +6,7 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
+- at.yawk.lz4:lz4-java:1.8.1
Review Comment:
Btw, upstream Apache Kafka (in trunk) has already migrated to the `at.yawk` fork and is [currently using version 1.10.1](https://github.com/apache/kafka/blob/trunk/gradle/dependencies.gradle#L113)
Since the Kafka connector will eventually depend on newer Kafka clients (which use 1.10.x), maybe it is safer to align directly with 1.10.1 instead of 1.8.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38764] Upgrade lz4 to 1.8.1 due to security vulnerability [flink]
Posted by "pnowojski (via GitHub)" <gi...@apache.org>.
pnowojski closed pull request #27326: [FLINK-38764] Upgrade lz4 to 1.8.1 due to security vulnerability
URL: https://github.com/apache/flink/pull/27326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38764] Upgrade lz4 to 1.8.1 due to security vulnerability [flink]
Posted by "sajjadrizvi (via GitHub)" <gi...@apache.org>.
sajjadrizvi commented on PR #27326:
URL: https://github.com/apache/flink/pull/27326#issuecomment-3769342730
How can we make this happen soon, moving to 1.10.1 and include it in the next Flink release, 1.20.4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38764] Upgrade lz4 to 1.8.1 due to security vulnerability [flink]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #27326:
URL: https://github.com/apache/flink/pull/27326#issuecomment-3655510745
Can we go to 1.10.1 because another CVE was reported - CVE-2025-66566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org