You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "cwespressif (via GitHub)" <gi...@apache.org> on 2025/03/07 11:57:01 UTC
[PR] esp32[s2|s3]: Add number of IRQ status lists for PHY initialization configuration [nuttx]
cwespressif opened a new pull request, #15954:
URL: https://github.com/apache/nuttx/pull/15954
## Summary
- esp32[s2|s3]: Add number of IRQ status lists for PHY initialization configuration
## Impact
- Configure `CONFIG_ESP_PHY_IRQSTATE_FLAGS_NUMBER` for more flexibility, please refer to the changes of [esp-hal-3rdparty](https://github.com/espressif/esp-hal-3rdparty/commit/5d4868f08b94efbe76383382f7a843c6cdeaf811)
New Feature/Change: No.
User Impact: No.
Build Impact: add `CONFIG_ESP_PHY_IRQSTATE_FLAGS_NUMBER` configuration.
Hardware Impact: No.
Security: No.
Compatibility: Backward-compatible, no breaking changes.
## Testing
Internal CI testing and ESP32/ESP32-S3 DevKit ostest.
Attached is the ostest log:
[ostest.txt](https://github.com/user-attachments/files/19125945/ostest.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] esp32[s2|s3]: Add number of IRQ status lists for PHY initialization configuration [nuttx]
Posted by "cwespressif (via GitHub)" <gi...@apache.org>.
cwespressif commented on PR #15954:
URL: https://github.com/apache/nuttx/pull/15954#issuecomment-2709351282
> commit log
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] esp32[s2|s3]: Add number of IRQ status lists for PHY initialization configuration [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #15954:
URL: https://github.com/apache/nuttx/pull/15954#issuecomment-2706535131
Hi Chen Weng, please include a commit log message explaining more details about its purpose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/xtensa/esp32[s2|s3]: Add number of IRQ status lists for PHY initialization configuration [nuttx]
Posted by "jerpelea (via GitHub)" <gi...@apache.org>.
jerpelea merged PR #15954:
URL: https://github.com/apache/nuttx/pull/15954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] esp32[s2|s3]: Add number of IRQ status lists for PHY initialization configuration [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #15954:
URL: https://github.com/apache/nuttx/pull/15954#issuecomment-2706275191
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
Yes, this PR appears to meet the NuttX requirements, although it could be improved with more detail in the "Testing" section. While it references CI testing and provides an ostest log, it lacks specifics on the build host and target environments used for verification. Explicitly stating the OS, architecture, board, and configuration tested would strengthen the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org