[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7664: Allow override distinctCount to segmentPartitionedDistinctCount

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #7664:
URL: https://github.com/apache/pinot/pull/7664#discussion_r739934691



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -270,6 +274,11 @@ private BrokerResponseNative handleSQLRequest(long requestId, String query, Json
     if (_enableQueryLimitOverride) {
       handleQueryLimitOverride(pinotQuery, _queryResponseLimit);
     }
+    if (_enableSegmentPartitionedDistinctCountOverride
+        || QueryOptionsUtils.enableSegmentPartitionedDistinctCountOverride(pinotQuery.getQueryOptions())) {
+      handleSegmentPartitionedDistinctCountOverride(pinotQuery,

Review comment:
       Yes, and that's the reason why I suggest modeling it as a query optimizer. Query optimizer is at broker, where we already have access to the table config




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org