You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rdblue <gi...@git.apache.org> on 2018/08/22 23:54:26 UTC

[GitHub] spark pull request #22193: [SPARK-25186][SQL] Remove v2 save mode.

GitHub user rdblue opened a pull request:

    https://github.com/apache/spark/pull/22193

    [SPARK-25186][SQL] Remove v2 save mode.

    ## What changes were proposed in this pull request?
    
    This removes `SaveMode` from the v2 write API. Overwrite is temporarily implemented by deleting path-based and name-based tables and appending. These appends implicitly create tables and should be replaced with CTAS and RTAS.
    
    ## How was this patch tested?
    
    Existing tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rdblue/spark remove-v2-save-mode

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22193.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22193
    
----
commit e3fcc83a4a55576821573ceb9a3a56b89218a187
Author: Ryan Blue <bl...@...>
Date:   2018-08-22T21:17:11Z

    SPARK-25188: Add WriteConfig to v2 write API.

commit 6dbc6e09b5a50764b29050ac30eb9c4f9f8970b8
Author: Ryan Blue <bl...@...>
Date:   2018-08-22T21:45:17Z

    SPARK-25188: BatchPartitionOverwriteSupport extends BatchWriteSupport.

commit 394c9d71ea46ce9d90d5c1c5a0309f29d0f6f5e6
Author: Ryan Blue <bl...@...>
Date:   2018-08-22T23:51:24Z

    Remove SaveMode from the v2 write API.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2503/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    **[Test build #95127 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95127/testReport)** for PR 22193 at commit [`394c9d7`](https://github.com/apache/spark/commit/394c9d71ea46ce9d90d5c1c5a0309f29d0f6f5e6).
     * This patch **fails to build**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2508/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    **[Test build #95176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95176/testReport)** for PR 22193 at commit [`0562041`](https://github.com/apache/spark/commit/05620413abb42d9160a8a4b4a3c983404671a885).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    **[Test build #95127 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95127/testReport)** for PR 22193 at commit [`394c9d7`](https://github.com/apache/spark/commit/394c9d71ea46ce9d90d5c1c5a0309f29d0f6f5e6).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by rdblue <gi...@git.apache.org>.
Github user rdblue commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    @HyukjinKwon, those changes probably don't need to be in this PR, but this is just a demonstration that we can remove `SaveMode` without changing test cases. The larger issue is that this doesn't correctly use CTAS or RTAS plans. Instead, it does things like directly deleting data.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95176/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95127/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    **[Test build #95181 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95181/testReport)** for PR 22193 at commit [`0017312`](https://github.com/apache/spark/commit/0017312cca51274d6fe2ed05de3bd2a2616abcab).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    **[Test build #95181 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95181/testReport)** for PR 22193 at commit [`0017312`](https://github.com/apache/spark/commit/0017312cca51274d6fe2ed05de3bd2a2616abcab).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95181/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    @rdblue, is it a mistake to include the commits for SPARK-25188?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    **[Test build #95176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95176/testReport)** for PR 22193 at commit [`0562041`](https://github.com/apache/spark/commit/05620413abb42d9160a8a4b4a3c983404671a885).
     * This patch **fails to build**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2463/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22193: [SPARK-25186][SQL] Remove v2 save mode.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22193
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org