You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/03/09 14:27:23 UTC
Review Request 57463: AMBARI-20365 Display Ranger DB backup
instruction in sections on the manual step during RU
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57463/
-----------------------------------------------------------
Review request for Ambari and Tim Thorpe.
Bugs: AMBARI-20365
https://issues.apache.org/jira/browse/AMBARI-20365
Repository: ambari
Description
-------
current approach is to use multiple <message> sections. Alejandro also suggested an alternative where a single <message> section can accept HTML markup for greater flexibility. The alternative approach will be treated as a feature request in a separate JIRA.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 6bf2d4c
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 91c8cdf
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml fd93829
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml da5265d
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 708c011
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml b1325b9
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 10ae959
Diff: https://reviews.apache.org/r/57463/diff/1/
Testing
-------
patched a trunk cluster run RU, verify messages were shown in sections.
Thanks,
Di Li
Re: Review Request 57463: AMBARI-20365 Display Ranger DB backup
instruction in sections on the manual step during RU
Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57463/#review168480
-----------------------------------------------------------
Ship it!
Ship It!
- Tim Thorpe
On March 9, 2017, 2:27 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57463/
> -----------------------------------------------------------
>
> (Updated March 9, 2017, 2:27 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-20365
> https://issues.apache.org/jira/browse/AMBARI-20365
>
>
> Repository: ambari
>
>
> Description
> -------
>
> current approach is to use multiple <message> sections. Alejandro also suggested an alternative where a single <message> section can accept HTML markup for greater flexibility. The alternative approach will be treated as a feature request in a separate JIRA.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 6bf2d4c
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 91c8cdf
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml fd93829
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml da5265d
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 708c011
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml b1325b9
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 10ae959
>
>
> Diff: https://reviews.apache.org/r/57463/diff/1/
>
>
> Testing
> -------
>
> patched a trunk cluster run RU, verify messages were shown in sections.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 57463: AMBARI-20365 Display Ranger DB backup
instruction in sections on the manual step during RU
Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57463/#review168639
-----------------------------------------------------------
Ship it!
Ship It!
- Tim Thorpe
On March 10, 2017, 4:44 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57463/
> -----------------------------------------------------------
>
> (Updated March 10, 2017, 4:44 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-20365
> https://issues.apache.org/jira/browse/AMBARI-20365
>
>
> Repository: ambari
>
>
> Description
> -------
>
> current approach is to use multiple <message> sections. Alejandro also suggested an alternative where a single <message> section can accept HTML markup for greater flexibility. The alternative approach will be treated as a feature request in a separate JIRA.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 6bf2d4c
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 91c8cdf
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml fd93829
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml c27b634
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 708c011
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml b1325b9
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml cb163e4
>
>
> Diff: https://reviews.apache.org/r/57463/diff/3/
>
>
> Testing
> -------
>
> patched a trunk cluster run RU, verify messages were shown in sections.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 57463: AMBARI-20365 Display Ranger DB backup
instruction in sections on the manual step during RU
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57463/
-----------------------------------------------------------
(Updated March 10, 2017, 4:44 p.m.)
Review request for Ambari and Tim Thorpe.
Bugs: AMBARI-20365
https://issues.apache.org/jira/browse/AMBARI-20365
Repository: ambari
Description
-------
current approach is to use multiple <message> sections. Alejandro also suggested an alternative where a single <message> section can accept HTML markup for greater flexibility. The alternative approach will be treated as a feature request in a separate JIRA.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 6bf2d4c
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 91c8cdf
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml fd93829
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml c27b634
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 708c011
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml b1325b9
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml cb163e4
Diff: https://reviews.apache.org/r/57463/diff/3/
Changes: https://reviews.apache.org/r/57463/diff/2-3/
Testing
-------
patched a trunk cluster run RU, verify messages were shown in sections.
Thanks,
Di Li
Re: Review Request 57463: AMBARI-20365 Display Ranger DB backup
instruction in sections on the manual step during RU
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57463/
-----------------------------------------------------------
(Updated March 9, 2017, 9:22 p.m.)
Review request for Ambari and Tim Thorpe.
Bugs: AMBARI-20365
https://issues.apache.org/jira/browse/AMBARI-20365
Repository: ambari
Description
-------
current approach is to use multiple <message> sections. Alejandro also suggested an alternative where a single <message> section can accept HTML markup for greater flexibility. The alternative approach will be treated as a feature request in a separate JIRA.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 6bf2d4c
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 91c8cdf
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml fd93829
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml da5265d
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 708c011
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml b1325b9
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 10ae959
Diff: https://reviews.apache.org/r/57463/diff/2/
Changes: https://reviews.apache.org/r/57463/diff/1-2/
Testing
-------
patched a trunk cluster run RU, verify messages were shown in sections.
Thanks,
Di Li
Re: Review Request 57463: AMBARI-20365 Display Ranger DB backup
instruction in sections on the manual step during RU
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57463/#review168520
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml
Line 100 (original), 100 (patched)
<https://reviews.apache.org/r/57463/#comment240758>
Missing a space before "If"
- Alejandro Fernandez
On March 9, 2017, 2:27 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57463/
> -----------------------------------------------------------
>
> (Updated March 9, 2017, 2:27 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-20365
> https://issues.apache.org/jira/browse/AMBARI-20365
>
>
> Repository: ambari
>
>
> Description
> -------
>
> current approach is to use multiple <message> sections. Alejandro also suggested an alternative where a single <message> section can accept HTML markup for greater flexibility. The alternative approach will be treated as a feature request in a separate JIRA.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 6bf2d4c
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 91c8cdf
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml fd93829
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml da5265d
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 708c011
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml b1325b9
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 10ae959
>
>
> Diff: https://reviews.apache.org/r/57463/diff/1/
>
>
> Testing
> -------
>
> patched a trunk cluster run RU, verify messages were shown in sections.
>
>
> Thanks,
>
> Di Li
>
>