You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/05/02 20:41:36 UTC
Review Request 33783: Add stats for update state transitions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33783/
-----------------------------------------------------------
Review request for Aurora and David McLaughlin.
Bugs: AURORA-1259
https://issues.apache.org/jira/browse/AURORA-1259
Repository: aurora
Description
-------
This required moving `FakeStatsProvider` from src/test to src/main, since it's now used by `DbUtil`. I'm not totally happy about that, but i didn't see a more favorable approach.
Diffs
-----
config/legacy_untested_classes.txt 4d090a8fc1344531772e1b7025d77c2ff0a30035
src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 94ce5c3499ced1b63abf19787acc21b2cd4d0c75
src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java a10a9e79c2e294d1f701e36a522e34222db1c3a3
src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 219676fab301542c129794416630070921225439
src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java f18619a27eeb2aea8dcf01e54c23ed7d1c7d3d87
src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java
Diff: https://reviews.apache.org/r/33783/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 33783: Add stats for update state transitions.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33783/#review82550
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On May 2, 2015, 6:41 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33783/
> -----------------------------------------------------------
>
> (Updated May 2, 2015, 6:41 p.m.)
>
>
> Review request for Aurora and David McLaughlin.
>
>
> Bugs: AURORA-1259
> https://issues.apache.org/jira/browse/AURORA-1259
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This required moving `FakeStatsProvider` from src/test to src/main, since it's now used by `DbUtil`. I'm not totally happy about that, but i didn't see a more favorable approach.
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt 4d090a8fc1344531772e1b7025d77c2ff0a30035
> src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 94ce5c3499ced1b63abf19787acc21b2cd4d0c75
> src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java a10a9e79c2e294d1f701e36a522e34222db1c3a3
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 219676fab301542c129794416630070921225439
> src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java f18619a27eeb2aea8dcf01e54c23ed7d1c7d3d87
> src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java
>
> Diff: https://reviews.apache.org/r/33783/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33783: Add stats for update state transitions.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33783/#review82322
-----------------------------------------------------------
Ship it!
Master (35c511e) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 2, 2015, 6:41 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33783/
> -----------------------------------------------------------
>
> (Updated May 2, 2015, 6:41 p.m.)
>
>
> Review request for Aurora and David McLaughlin.
>
>
> Bugs: AURORA-1259
> https://issues.apache.org/jira/browse/AURORA-1259
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This required moving `FakeStatsProvider` from src/test to src/main, since it's now used by `DbUtil`. I'm not totally happy about that, but i didn't see a more favorable approach.
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt 4d090a8fc1344531772e1b7025d77c2ff0a30035
> src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 94ce5c3499ced1b63abf19787acc21b2cd4d0c75
> src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java a10a9e79c2e294d1f701e36a522e34222db1c3a3
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 219676fab301542c129794416630070921225439
> src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java f18619a27eeb2aea8dcf01e54c23ed7d1c7d3d87
> src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java
>
> Diff: https://reviews.apache.org/r/33783/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>