[GitHub] [incubator-brpc] serverglen commented on a diff in pull request #1964: support mvariable dump by prometheus rpc service

[GitBox <gi...@apache.org>]

serverglen commented on code in PR #1964:
URL: https://github.com/apache/incubator-brpc/pull/1964#discussion_r1005599888


##########
src/brpc/builtin/prometheus_metrics_service.cpp:
##########
@@ -200,6 +200,13 @@ int DumpPrometheusMetricsToIOBuf(butil::IOBuf* output) {
         return -1;
     }
     os.move_to(*output);
+
+    PrometheusMetricsDumper dumper_md(&os, g_server_info_prefix);

Review Comment:
   是不是加个flags开关比较好？默认不输出多维度bvar。毕竟有些mbvar的维度可能比较多。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org