You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cfmcgrady (via GitHub)" <gi...@apache.org> on 2023/06/28 10:31:56 UTC
[GitHub] [incubator-celeborn] cfmcgrady commented on a diff in pull request #1639: [CELEBORN-726] Update data replication terminology from 'master/slave' to 'primary/replica' in the codebase
cfmcgrady commented on code in PR #1639:
URL: https://github.com/apache/incubator-celeborn/pull/1639#discussion_r1245019219
##########
METRICS.md:
##########
@@ -73,8 +73,8 @@ Here is an example of grafana dashboard importing.
| FlushDataTime | worker | FlushData means flush a disk buffer to disk. |
| OpenStreamTime | worker | OpenStream means read a shuffle file and send client about chunks size and stream index. |
| FetchChunkTime | worker | FetchChunk means read a chunk from a shuffle file and send to client. |
-| MasterPushDataTime | worker | MasterPushData means handle pushdata of master partition location. |
-| SlavePushDataTime | worker | SlavePushData means handle pushdata of slave partition location. |
+| PrimaryPushDataTime | worker | PrimaryPushData means handle pushdata of primary partition location. |
+| ReplicaPushDataTime | worker | ReplicaPushData means handle pushdata of replica partition location. |
Review Comment:
shall we put the change note in the section `Upgrading from 0.2 to 0.3`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org