You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2024/11/21 13:58:58 UTC
[I] [Dev] Add top-level `.editorconfig` for C++, Python... [arrow]
pitrou opened a new issue, #44805:
URL: https://github.com/apache/arrow/issues/44805
### Describe the enhancement requested
See https://editorconfig.org/
Some languages such as Python, C++, bash... are used in various parts of our repository, a top-level `.editorconfig` would help maintain a consistent style at least for the basics (such as indentation).
### Component(s)
C++, Developer Tools, Python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Dev] Add top-level `.editorconfig` for C++, Python... [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #44805:
URL: https://github.com/apache/arrow/issues/44805#issuecomment-2492663842
We should check our style by `pre-commit` even if we have `.editorconfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Dev] Add top-level `.editorconfig` for C++, Python... [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #44805:
URL: https://github.com/apache/arrow/issues/44805#issuecomment-2491272274
Thoughts @kou @raulcd @assignUser ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Dev] Add top-level `.editorconfig` for C++, Python... [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #44805:
URL: https://github.com/apache/arrow/issues/44805#issuecomment-2495176296
It seems pretty unintrusive and useful :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Dev] Add top-level `.editorconfig` for C++, Python... [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou closed issue #44805: [Dev] Add top-level `.editorconfig` for C++, Python...
URL: https://github.com/apache/arrow/issues/44805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Dev] Add top-level `.editorconfig` for C++, Python... [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #44805:
URL: https://github.com/apache/arrow/issues/44805#issuecomment-2511802833
Issue resolved by pull request 44870
https://github.com/apache/arrow/pull/44870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Dev] Add top-level `.editorconfig` for C++, Python... [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #44805:
URL: https://github.com/apache/arrow/issues/44805#issuecomment-2492662486
I'm OK with this but I don't want to maintain `.editorconfig` too much to align with our clang-format configuration.
If we have `.editorconfig`, we can remove `**/.dir-locals.el` added by me. :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Dev] Add top-level `.editorconfig` for C++, Python... [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #44805:
URL: https://github.com/apache/arrow/issues/44805#issuecomment-2493281223
The EditorConfig spec is [extremely basic](https://spec.editorconfig.org/#supported-pairs) for now, it mostly only covers indentation and line endings. But it would help working on multiple projects with different indentation settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org