You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Sebastian Schelter (JIRA)" <ji...@apache.org> on 2011/02/04 18:20:30 UTC
[jira] Created: (MAHOUT-607) Count used and neglected elements in
MaybePruneRowsMapper
Count used and neglected elements in MaybePruneRowsMapper
---------------------------------------------------------
Key: MAHOUT-607
URL: https://issues.apache.org/jira/browse/MAHOUT-607
Project: Mahout
Issue Type: Improvement
Components: Collaborative Filtering
Affects Versions: 0.4
Reporter: Sebastian Schelter
Assignee: Sean Owen
Priority: Minor
Fix For: 0.5
MaybePruneRowsMapper is used to prune the overall number of preferences/ratings our distributed recommender looks at. The patch adds counters to the code so we can see the number of used and neglected preferences in the jobtracker.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAHOUT-607) Count used and neglected elements in
MaybePruneRowsMapper
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990738#comment-12990738 ]
Sean Owen commented on MAHOUT-607:
----------------------------------
Really? I don't know of many uses of counters. I was just thinking of renaming the enums, and maybe changing a few constant names. I don't think anyone would mind standardization on an inner enum called Counters or whatever, plus some sensible naming convention. Well, do whatever you think is appropriate.
> Count used and neglected elements in MaybePruneRowsMapper
> ---------------------------------------------------------
>
> Key: MAHOUT-607
> URL: https://issues.apache.org/jira/browse/MAHOUT-607
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Affects Versions: 0.4
> Reporter: Sebastian Schelter
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 0.5
>
> Attachments: MAHOUT-607.patch
>
>
> MaybePruneRowsMapper is used to prune the overall number of preferences/ratings our distributed recommender looks at. The patch adds counters to the code so we can see the number of used and neglected preferences in the jobtracker.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAHOUT-607) Count used and neglected elements in
MaybePruneRowsMapper
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990746#comment-12990746 ]
Hudson commented on MAHOUT-607:
-------------------------------
Integrated in Mahout-Quality #611 (See [https://hudson.apache.org/hudson/job/Mahout-Quality/611/])
MAHOUT-607 Count used and neglected elements in MaybePruneRowsMapper
> Count used and neglected elements in MaybePruneRowsMapper
> ---------------------------------------------------------
>
> Key: MAHOUT-607
> URL: https://issues.apache.org/jira/browse/MAHOUT-607
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Affects Versions: 0.4
> Reporter: Sebastian Schelter
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 0.5
>
> Attachments: MAHOUT-607.patch
>
>
> MaybePruneRowsMapper is used to prune the overall number of preferences/ratings our distributed recommender looks at. The patch adds counters to the code so we can see the number of used and neglected preferences in the jobtracker.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAHOUT-607) Count used and neglected elements in
MaybePruneRowsMapper
Posted by "Sebastian Schelter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Schelter updated MAHOUT-607:
--------------------------------------
Attachment: MAHOUT-607.patch
> Count used and neglected elements in MaybePruneRowsMapper
> ---------------------------------------------------------
>
> Key: MAHOUT-607
> URL: https://issues.apache.org/jira/browse/MAHOUT-607
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Affects Versions: 0.4
> Reporter: Sebastian Schelter
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 0.5
>
> Attachments: MAHOUT-607.patch
>
>
> MaybePruneRowsMapper is used to prune the overall number of preferences/ratings our distributed recommender looks at. The patch adds counters to the code so we can see the number of used and neglected preferences in the jobtracker.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAHOUT-607) Count used and neglected elements in
MaybePruneRowsMapper
Posted by "Sebastian Schelter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990644#comment-12990644 ]
Sebastian Schelter commented on MAHOUT-607:
-------------------------------------------
I had it named "Counters" too, but when I looked into MinHashReducer I saw that a more descriptive enum name was used there. Maybe we can agree on some convention?
> Count used and neglected elements in MaybePruneRowsMapper
> ---------------------------------------------------------
>
> Key: MAHOUT-607
> URL: https://issues.apache.org/jira/browse/MAHOUT-607
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Affects Versions: 0.4
> Reporter: Sebastian Schelter
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 0.5
>
> Attachments: MAHOUT-607.patch
>
>
> MaybePruneRowsMapper is used to prune the overall number of preferences/ratings our distributed recommender looks at. The patch adds counters to the code so we can see the number of used and neglected preferences in the jobtracker.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAHOUT-607) Count used and neglected elements in
MaybePruneRowsMapper
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen updated MAHOUT-607:
-----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Count used and neglected elements in MaybePruneRowsMapper
> ---------------------------------------------------------
>
> Key: MAHOUT-607
> URL: https://issues.apache.org/jira/browse/MAHOUT-607
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Affects Versions: 0.4
> Reporter: Sebastian Schelter
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 0.5
>
> Attachments: MAHOUT-607.patch
>
>
> MaybePruneRowsMapper is used to prune the overall number of preferences/ratings our distributed recommender looks at. The patch adds counters to the code so we can see the number of used and neglected preferences in the jobtracker.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAHOUT-607) Count used and neglected elements in
MaybePruneRowsMapper
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990645#comment-12990645 ]
Sean Owen commented on MAHOUT-607:
----------------------------------
Sure, pick any convention you think is reasonable and feel free to rename all the other such enums you find.
> Count used and neglected elements in MaybePruneRowsMapper
> ---------------------------------------------------------
>
> Key: MAHOUT-607
> URL: https://issues.apache.org/jira/browse/MAHOUT-607
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Affects Versions: 0.4
> Reporter: Sebastian Schelter
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 0.5
>
> Attachments: MAHOUT-607.patch
>
>
> MaybePruneRowsMapper is used to prune the overall number of preferences/ratings our distributed recommender looks at. The patch adds counters to the code so we can see the number of used and neglected preferences in the jobtracker.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAHOUT-607) Count used and neglected elements in
MaybePruneRowsMapper
Posted by "Sebastian Schelter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Schelter updated MAHOUT-607:
--------------------------------------
Status: Patch Available (was: Open)
will commit this in the next days if there are no objections.
> Count used and neglected elements in MaybePruneRowsMapper
> ---------------------------------------------------------
>
> Key: MAHOUT-607
> URL: https://issues.apache.org/jira/browse/MAHOUT-607
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Affects Versions: 0.4
> Reporter: Sebastian Schelter
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 0.5
>
> Attachments: MAHOUT-607.patch
>
>
> MaybePruneRowsMapper is used to prune the overall number of preferences/ratings our distributed recommender looks at. The patch adds counters to the code so we can see the number of used and neglected preferences in the jobtracker.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAHOUT-607) Count used and neglected elements in
MaybePruneRowsMapper
Posted by "Sebastian Schelter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990676#comment-12990676 ]
Sebastian Schelter commented on MAHOUT-607:
-------------------------------------------
There are too much different counter naming strategies in the code to include them in a quick refactoring effort here. We should maybe address this in a separate issue.
> Count used and neglected elements in MaybePruneRowsMapper
> ---------------------------------------------------------
>
> Key: MAHOUT-607
> URL: https://issues.apache.org/jira/browse/MAHOUT-607
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Affects Versions: 0.4
> Reporter: Sebastian Schelter
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 0.5
>
> Attachments: MAHOUT-607.patch
>
>
> MaybePruneRowsMapper is used to prune the overall number of preferences/ratings our distributed recommender looks at. The patch adds counters to the code so we can see the number of used and neglected preferences in the jobtracker.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAHOUT-607) Count used and neglected elements in
MaybePruneRowsMapper
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990640#comment-12990640 ]
Sean Owen commented on MAHOUT-607:
----------------------------------
Yes I like the idea of counting more things as it aids visibility into the pipeline at run-time. The patch is fine by me, FWIW. I also use an inner enum, though I had usually called it "Counters".
> Count used and neglected elements in MaybePruneRowsMapper
> ---------------------------------------------------------
>
> Key: MAHOUT-607
> URL: https://issues.apache.org/jira/browse/MAHOUT-607
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Affects Versions: 0.4
> Reporter: Sebastian Schelter
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 0.5
>
> Attachments: MAHOUT-607.patch
>
>
> MaybePruneRowsMapper is used to prune the overall number of preferences/ratings our distributed recommender looks at. The patch adds counters to the code so we can see the number of used and neglected preferences in the jobtracker.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira