You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Christopher Blythe <cj...@gmail.com> on 2006/10/24 15:06:41 UTC
Re: Submitting patches with new files?
Thanks for the response Paul... that makes sense. Why are the most obvious
things the hardest to find? ;-)
On 10/23/06, Paul McMahan <pa...@gmail.com> wrote:
>
> Chris, if you check out the src tree using svn then use "svn add" to
> add files to your local copy. Then the new files will be in the
> resulting patch generated when you type "svn diff".
>
> Best wishes,
> Paul
>
> On 10/23/06, Christopher Blythe <cj...@gmail.com> wrote:
> > What is the best method for submitting a patch that contains new files?
> From
> > what I have read and seen on my own, the cmd line based subversion diff
> > command does not include them in the resulting patch file. Or, am I
> missing
> > something?
> >
> > Thanks...
> >
> > Chris
> >
> > --
> > "I say never be complete, I say stop being perfect, I say let... lets
> > evolve, let the chips fall where they may." - Tyler Durden
>
--
"I say never be complete, I say stop being perfect, I say let... lets
evolve, let the chips fall where they may." - Tyler Durden
Re: Submitting patches with new files?
Posted by Paul McMahan <pa...@gmail.com>.
Christopher, you can attach the binary files to the same JIRA you
attach your patch to. If there are several binary files then you may
want to collect them in a zip or tgz first.
Best wishes,
Paul
On 10/24/06, Christopher Blythe <cj...@gmail.com> wrote:
> As a follow up question... what is the best means of handling new and/or
> updates to binary files when creating a patch? I noticed from one of my
> diff files something similar to the following...
>
> Index:
> modules/dojo-ui-web/src/main/webapp/storage_dialog.swf
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
>
> Property changes on:
> modules/dojo-ui-web/src/main/webapp/storage_dialog.swf
> ___________________________________________________________________
> Name: svn:mime-type
> + application/octet-stream
>
> Thanks again...
>
> Chris
>
>
>
> On 10/24/06, Christopher Blythe <cj...@gmail.com> wrote:
> > Thanks for the response Paul... that makes sense. Why are the most obvious
> things the hardest to find? ;-)
> >
> >
> >
> > On 10/23/06, Paul McMahan < paulmcmahan@gmail.com> wrote:
> > > Chris, if you check out the src tree using svn then use "svn add" to
> > > add files to your local copy. Then the new files will be in the
> > > resulting patch generated when you type "svn diff".
> > >
> > > Best wishes,
> > > Paul
> > >
> > > On 10/23/06, Christopher Blythe < cjblythe25@gmail.com> wrote:
> > > > What is the best method for submitting a patch that contains new
> files? From
> > > > what I have read and seen on my own, the cmd line based subversion
> diff
> > > > command does not include them in the resulting patch file. Or, am I
> missing
> > > > something?
> > > >
> > > > Thanks...
> > > >
> > > > Chris
> > > >
> > > > --
> > > > "I say never be complete, I say stop being perfect, I say let... lets
> > > > evolve, let the chips fall where they may." - Tyler Durden
> > >
> >
> >
> >
> > --
> >
> > "I say never be complete, I say stop being perfect, I say let... lets
> evolve, let the chips fall where they may." - Tyler Durden
>
>
>
> --
>
> "I say never be complete, I say stop being perfect, I say let... lets
> evolve, let the chips fall where they may." - Tyler Durden
Re: Submitting patches with new files?
Posted by Christopher Blythe <cj...@gmail.com>.
As a follow up question... what is the best means of handling new and/or
updates to binary files when creating a patch? I noticed from one of my
diff files something similar to the following...
Index: modules/dojo-ui-web/src/main/webapp/storage_dialog.swf
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: modules/dojo-ui-web/src/main/webapp/storage_dialog.swf
___________________________________________________________________
Name: svn:mime-type
+ application/octet-stream
Thanks again...
Chris
On 10/24/06, Christopher Blythe <cj...@gmail.com> wrote:
>
> Thanks for the response Paul... that makes sense. Why are the most obvious
> things the hardest to find? ;-)
>
> On 10/23/06, Paul McMahan < paulmcmahan@gmail.com> wrote:
> >
> > Chris, if you check out the src tree using svn then use "svn add" to
> > add files to your local copy. Then the new files will be in the
> > resulting patch generated when you type "svn diff".
> >
> > Best wishes,
> > Paul
> >
> > On 10/23/06, Christopher Blythe < cjblythe25@gmail.com> wrote:
> > > What is the best method for submitting a patch that contains new
> > files? From
> > > what I have read and seen on my own, the cmd line based subversion
> > diff
> > > command does not include them in the resulting patch file. Or, am I
> > missing
> > > something?
> > >
> > > Thanks...
> > >
> > > Chris
> > >
> > > --
> > > "I say never be complete, I say stop being perfect, I say let... lets
> > > evolve, let the chips fall where they may." - Tyler Durden
> >
>
>
>
> --
> "I say never be complete, I say stop being perfect, I say let... lets
> evolve, let the chips fall where they may." - Tyler Durden
>
--
"I say never be complete, I say stop being perfect, I say let... lets
evolve, let the chips fall where they may." - Tyler Durden