You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/08 01:32:57 UTC

[GitHub] [arrow] jacques-n commented on pull request #6433: ARROW-7495: [Java] Remove "empty" concept from ArrowBuf, replace with custom referencemanager

jacques-n commented on pull request #6433:
URL: https://github.com/apache/arrow/pull/6433#issuecomment-625580179


   I think it would be good to have a set of tests ensuring that the behavior of the empty buffer is consistent. For example, refcnt, release/allocate, etc. That way, if someone changes the noop reference manager which this is depending on in the future, we don't break the expected behavior of an EmptyBuf as used by all the vector classes. Other than that, this looks good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org