You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/02/01 10:24:06 UTC
[PR] Add support for Junit5 tests [bookkeeper]
lhotari opened a new pull request, #4197:
URL: https://github.com/apache/bookkeeper/pull/4197
### Motivation
Add support for JUnit 5 tests so that tests can be written in modern ways. Parameterized tests in Junit 4 are painful.
### Changes
- upgrade surefire plugin
- replace <forkMode>always</forkMode> with supported way in newer maven-surefire-plugin
- maven-failsafe-plugin version must match maven-surefire-plugin version
- remove invalid test case. Log4j is in the classpath for other reasons checked by running "mvn -pl tests/integration-tests-utils/pom.xml test -X" also verified by debugging that it's not in the system classpath, it is loaded by the MavenClassLoader
- add assertj-core for fluent assertions in tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for Junit5 tests [bookkeeper]
Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 commented on PR #4197:
URL: https://github.com/apache/bookkeeper/pull/4197#issuecomment-1921412356
Good job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for Junit5 tests [bookkeeper]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #4197:
URL: https://github.com/apache/bookkeeper/pull/4197#issuecomment-1920990737
@merlimat @hangc0276 @BewareMyPower please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for Junit5 tests and fix CI that has been broken [bookkeeper]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #4197:
URL: https://github.com/apache/bookkeeper/pull/4197#issuecomment-1933488539
> merging as soon as CI passes
@eolivelli Integration tests have been ignored in apache/bookkeeper CI for a very long time. Here's some evidence: https://github.com/apache/bookkeeper/pull/3675#issuecomment-1933485215 . I had to fix a bug in `bkctl ledger simpletest" `and it appears that it was already merged as invalid in November 2022. 😱
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for Junit5 tests and fix CI that has been broken [bookkeeper]
Posted by "eolivelli (via GitHub)" <gi...@apache.org>.
eolivelli commented on PR #4197:
URL: https://github.com/apache/bookkeeper/pull/4197#issuecomment-1932154858
merging as soon as CI passes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for Junit5 tests and fix CI that has been broken [bookkeeper]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #4197:
URL: https://github.com/apache/bookkeeper/pull/4197#discussion_r1476113667
##########
circe-checksum/pom.xml:
##########
@@ -80,8 +80,28 @@
<plugin>
<groupId>com.github.maven-nar</groupId>
<artifactId>nar-maven-plugin</artifactId>
- <version>${nar-maven-plugin.version}</version>
<extensions>true</extensions>
+ <configuration>
+ <runtime>${nar.runtime}</runtime>
+ <output>circe-checksum</output>
+ <libraries>
+ <library>
+ <type>jni</type>
+ <narSystemPackage>com.scurrilous.circe.checksum</narSystemPackage>
+ </library>
+ </libraries>
+ <cpp>
+ <optionSet>${nar.cpp.optionSet}</optionSet>
+ <exceptions>false</exceptions>
+ <rtti>false</rtti>
+ <optimize>full</optimize>
+ <includes>
+ <include>**/*.cpp</include>
Review Comment:
This is the actual fix for circe-checksum native library compilation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for Junit5 tests [bookkeeper]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #4197:
URL: https://github.com/apache/bookkeeper/pull/4197#issuecomment-1920991269
@nicoloboschi @eolivelli please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for Junit5 tests and fix CI that has been broken [bookkeeper]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #4197:
URL: https://github.com/apache/bookkeeper/pull/4197#discussion_r1476113667
##########
circe-checksum/pom.xml:
##########
@@ -80,8 +80,28 @@
<plugin>
<groupId>com.github.maven-nar</groupId>
<artifactId>nar-maven-plugin</artifactId>
- <version>${nar-maven-plugin.version}</version>
<extensions>true</extensions>
+ <configuration>
+ <runtime>${nar.runtime}</runtime>
+ <output>circe-checksum</output>
+ <libraries>
+ <library>
+ <type>jni</type>
+ <narSystemPackage>com.scurrilous.circe.checksum</narSystemPackage>
+ </library>
+ </libraries>
+ <cpp>
+ <optionSet>${nar.cpp.optionSet}</optionSet>
+ <exceptions>false</exceptions>
+ <rtti>false</rtti>
+ <optimize>full</optimize>
+ <includes>
+ <include>**/*.cpp</include>
Review Comment:
This is the actual fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for Junit5 tests and fix CI that has been broken [bookkeeper]
Posted by "eolivelli (via GitHub)" <gi...@apache.org>.
eolivelli merged PR #4197:
URL: https://github.com/apache/bookkeeper/pull/4197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org