You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2023/01/22 11:46:08 UTC

[GitHub] [streampipes] bossenti created a discussion: Extend FunctionDefinition by a function type id

GitHub user bossenti created a discussion: Extend FunctionDefinition by a function type id

While browsing through the API endpoint for SteamPipes functions I had the feeling that an additional attribute that identifies the type of a function could be valuable for the `[FunctionDefinition](https://github.com/apache/streampipes/blob/cf33668a016921dc831ea90476fa07158dc91b7e/streampipes-model/src/main/java/org/apache/streampipes/model/function/FunctionDefinition.java#L27)` class. This would allow a client to map existing functions in StreamPipes to the underlying implementation. How do you like that @dominikriemer?
Does this even make sense? 

GitHub link: https://github.com/apache/streampipes/discussions/1143

----
This is an automatically sent email for dev@streampipes.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@streampipes.apache.org


[GitHub] [streampipes] bossenti edited a discussion: Extend FunctionDefinition by a function type id

Posted by GitBox <gi...@apache.org>.
GitHub user bossenti edited a discussion: Extend FunctionDefinition by a function type id

While browsing through the API endpoint for SteamPipes functions I had the feeling that an additional attribute that identifies the type of a function could be valuable for the [`FunctionDefinition`](https://github.com/apache/streampipes/blob/cf33668a016921dc831ea90476fa07158dc91b7e/streampipes-model/src/main/java/org/apache/streampipes/model/function/FunctionDefinition.java#L27) class. This would allow a client to map existing functions in StreamPipes to the underlying implementation and directly create an instance of the function from the API response. How do you like that @dominikriemer?
Does this even make sense? 

GitHub link: https://github.com/apache/streampipes/discussions/1143

----
This is an automatically sent email for dev@streampipes.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@streampipes.apache.org


[GitHub] [streampipes] bossenti edited a discussion: Extend FunctionDefinition by a function type id

Posted by GitBox <gi...@apache.org>.
GitHub user bossenti edited a discussion: Extend FunctionDefinition by a function type id

While browsing through the API endpoint for SteamPipes functions I had the feeling that an additional attribute that identifies the type of a function could be valuable for the [`FunctionDefinition`](https://github.com/apache/streampipes/blob/cf33668a016921dc831ea90476fa07158dc91b7e/streampipes-model/src/main/java/org/apache/streampipes/model/function/FunctionDefinition.java#L27) class. This would allow a client to map existing functions in StreamPipes to the underlying implementation. How do you like that @dominikriemer?
Does this even make sense? 

GitHub link: https://github.com/apache/streampipes/discussions/1143

----
This is an automatically sent email for dev@streampipes.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@streampipes.apache.org


[GitHub] [streampipes] dominikriemer added a comment to the discussion: Extend FunctionDefinition by a function type id

Posted by GitBox <gi...@apache.org>.
GitHub user dominikriemer added a comment to the discussion: Extend FunctionDefinition by a function type id

Hi @bossenti can you provide an example how using the type identifier would work?
Currently, the function is only registered in the core to enable monitoring, while the implementation purely exists on the extensions service.

GitHub link: https://github.com/apache/streampipes/discussions/1143#discussioncomment-4754218

----
This is an automatically sent email for dev@streampipes.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@streampipes.apache.org


[GitHub] [streampipes] bossenti edited a comment on the discussion: Extend FunctionDefinition by a function type id

Posted by GitBox <gi...@apache.org>.
GitHub user bossenti edited a comment on the discussion: Extend FunctionDefinition by a function type id

So lets say I implement a `FunctionA` that has `some-id` as `functionTypeId` and create an instance of this that registers itself in the core. My idea is that this information enables you to do something like `FunctionHandler.from(functionDefinition)` that uses the information provided by `functionDefinition` to instantiate a `FunctionA`. Thereby, `some-id` is used to get the mapping to the `FunctionA` class. Do you understand what my intention is? 🤓

GitHub link: https://github.com/apache/streampipes/discussions/1143#discussioncomment-4758628

----
This is an automatically sent email for dev@streampipes.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@streampipes.apache.org


[GitHub] [streampipes] bossenti edited a discussion: Extend FunctionDefinition by a function type id

Posted by GitBox <gi...@apache.org>.
GitHub user bossenti edited a discussion: Extend FunctionDefinition by a function type id

While browsing through the API endpoint for SteamPipes functions I had the feeling that an additional attribute that identifies the type of a function could be valuable for the [`FunctionDefinition`](https://github.com/apache/streampipes/blob/cf33668a016921dc831ea90476fa07158dc91b7e/streampipes-model/src/main/java/org/apache/streampipes/model/function/FunctionDefinition.java#L27) class. This would allow a client to map existing functions in StreamPipes to the underlying implementation and to directly create an instance of the function from the API response. How do you like that @dominikriemer?
Does this even make sense? 

GitHub link: https://github.com/apache/streampipes/discussions/1143

----
This is an automatically sent email for dev@streampipes.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@streampipes.apache.org


[GitHub] [streampipes] bossenti added a comment to the discussion: Extend FunctionDefinition by a function type id

Posted by GitBox <gi...@apache.org>.
GitHub user bossenti added a comment to the discussion: Extend FunctionDefinition by a function type id

So lets say I implement a `FunctionA` that has `some-id` as `functionTypeId` and create an instance of this that registers itself in the core. My idea is that this information enables you to do something like `FunctionA.from(functionDefinition)` that uses the information provided by `functionDefinition` to instantiate a `FunctionA`. Do you understand what my intention is? 🤓

GitHub link: https://github.com/apache/streampipes/discussions/1143#discussioncomment-4758628

----
This is an automatically sent email for dev@streampipes.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@streampipes.apache.org


[GitHub] [streampipes] bossenti edited a comment on the discussion: Extend FunctionDefinition by a function type id

Posted by GitBox <gi...@apache.org>.
GitHub user bossenti edited a comment on the discussion: Extend FunctionDefinition by a function type id

So lets say I implement a `FunctionA` that has `some-id` as `functionTypeId` and create an instance of this that registers itself in the core. My idea is that this information enables you to do something like `FunctionHandler.from(functionDefinition)` that uses the information provided by `functionDefinition` to instantiate a `FunctionA`. Do you understand what my intention is? 🤓

GitHub link: https://github.com/apache/streampipes/discussions/1143#discussioncomment-4758628

----
This is an automatically sent email for dev@streampipes.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@streampipes.apache.org