You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:02:12 UTC

[GitHub] [ozone] sodonnel commented on a diff in pull request #3791: HDDS-7282. Add EstimatedKeyCount metrics for SCM DB

sodonnel commented on code in PR #3791:
URL: https://github.com/apache/ozone/pull/3791#discussion_r985631511


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/metadata/SCMMetadataStoreImpl.java:
##########
@@ -190,6 +200,9 @@ public void start(OzoneConfiguration config)
 
       checkTableStatus(statefulServiceConfigTable,
           STATEFUL_SERVICE_CONFIG.getName());
+
+      mxBean = MBeans.register("SCMMetadataStore", "SCMMetadataStoreImpl",

Review Comment:
   I suspect this needs an "unRegister" in the `stop()` method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org