You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/04/30 16:34:56 UTC

[GitHub] [netbeans] graben opened a new pull request #2113: [TRAVIS] Add missing license to correct failing verification

graben opened a new pull request #2113:
URL: https://github.com/apache/netbeans/pull/2113


   @ebarboni : Should be merge to avoid actual travis build to fail.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] graben commented on pull request #2113: [TRAVIS] Add missing license to correct failing verification

Posted by GitBox <gi...@apache.org>.
graben commented on pull request #2113:
URL: https://github.com/apache/netbeans/pull/2113#issuecomment-621975817


   Hi @lkishalmi, your latest Freemarker update from #2067 seems to break Travis build at all. Hopefully I fixed the right thing on the fly ;)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] graben commented on pull request #2113: [TRAVIS] Add missing license to correct failing verification

Posted by GitBox <gi...@apache.org>.
graben commented on pull request #2113:
URL: https://github.com/apache/netbeans/pull/2113#issuecomment-622274777


   Just fixed another minor file returning 2.3.19 instead of 2.3.30.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] graben commented on pull request #2113: [TRAVIS] Add missing license to correct failing verification

Posted by GitBox <gi...@apache.org>.
graben commented on pull request #2113:
URL: https://github.com/apache/netbeans/pull/2113#issuecomment-622035877


   Ignore failing tests for now. Must be completely rewritten since freemarker has changed it error handling. Much more chatty :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #2113: [TRAVIS] Add missing license to correct failing verification

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2113:
URL: https://github.com/apache/netbeans/pull/2113#issuecomment-622236019


   Thanks for fixing my bad. I do not know how could I push that incomplete PR in the first place. I'm sorry.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] graben edited a comment on pull request #2113: [TRAVIS] Add missing license to correct failing verification

Posted by GitBox <gi...@apache.org>.
graben edited a comment on pull request #2113:
URL: https://github.com/apache/netbeans/pull/2113#issuecomment-621999471


   Well, also unit test seems to fail for Freemarker.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] jlahoda commented on pull request #2113: [TRAVIS] Add missing license to correct failing verification

Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #2113:
URL: https://github.com/apache/netbeans/pull/2113#issuecomment-622262761


   Looks good to me. Eric, unless there are objections, or unless you want to do it yourself, I'll merge in a few hours. (The only alternative I see would be to revert #2067 - but I think fixing it is better!)
   
   Thanks @graben for fixing this!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] graben commented on pull request #2113: [TRAVIS] Add missing license to correct failing verification

Posted by GitBox <gi...@apache.org>.
graben commented on pull request #2113:
URL: https://github.com/apache/netbeans/pull/2113#issuecomment-621999471


   Well, there also unit test seems to fail.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists